Reply To All Icon Update



I've used my limited artistic abilities to create a new "Reply To All" icon
in response to a previous user suggestion on this list.  Included is a patch
which adds the icons (and fixes some other small bugs), and two xpm files
that need to be added to the repository in "balsa/src/pixmaps/".  

MBG

-- 
  Matthew Guenther                      If I want your opinion, I'll ask you
  mguenthe@netcom.ca                    to fill out the necessary form.
  http://www.netcom.ca/~mguenthe/
=== cd /home/mguenthe/src/balsa/
=== cvs diff -c ChangeLog

Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/balsa/ChangeLog,v
retrieving revision 1.168
diff -c -r1.168 ChangeLog
*** ChangeLog	2000/03/29 03:14:43	1.168
--- ChangeLog	2000/03/31 00:58:11
***************
*** 1,3 ****
--- 1,8 ----
+ 2000-03-30  Matthew Guenther <mguenther@netcom.ca>
+ 	* src/main-window.c: changed reply to all to use reply_to_all.xpm, 
+ 	and reply_to_all_menu.xpm, pointer casting bug.
+ 	* src/pref-manager.c: fixed pointer casting bug.
+ 
  2000-03-28  Peter Williams <peter@newton.cx>
  	* libbalsa/files.{c,h}: created balsa_file_finder,
  	  a *working* version of gnome_xxxx_file()
=== Exit status: 1
=== cd /home/mguenthe/src/balsa/src/
=== cvs diff -c balsa-icons.h main-window.c main.c pref-manager.c

Index: balsa-icons.h
===================================================================
RCS file: /cvs/gnome/balsa/src/balsa-icons.h,v
retrieving revision 1.1
diff -c -r1.1 balsa-icons.h
*** balsa-icons.h	1998/12/12 19:52:15	1.1
--- balsa-icons.h	2000/03/31 00:58:52
***************
*** 36,41 ****
--- 36,42 ----
      BALSA_ICON_FORWARDED,
  
      BALSA_ICON_ENVELOPE
+ 
    }
  BalsaIconName;
  
Index: main-window.c
===================================================================
RCS file: /cvs/gnome/balsa/src/main-window.c,v
retrieving revision 1.262
diff -c -r1.262 main-window.c
*** main-window.c	2000/03/29 03:14:47	1.262
--- main-window.c	2000/03/31 00:58:52
***************
*** 62,67 ****
--- 62,70 ----
  
  #define APPBAR_KEY "balsa_appbar"
  
+ #include "pixmaps/reply_to_all.xpm"
+ #include "pixmaps/reply_to_all_menu.xpm"
+ 
  enum {
    SET_CURSOR,
    OPEN_MAILBOX,
***************
*** 246,253 ****
    {
      GNOME_APP_UI_ITEM, N_ ("Reply to _all"),
      N_("Reply to all recipients of the current message"),
!     replytoall_message_cb, NULL, NULL, GNOME_APP_PIXMAP_STOCK,
!     GNOME_STOCK_MENU_MAIL_RPL, 'A', 0, NULL
    },
  #define MENU_MESSAGE_FORWARD_POS 7
      /* F */
--- 249,256 ----
    {
      GNOME_APP_UI_ITEM, N_ ("Reply to _all"),
      N_("Reply to all recipients of the current message"),
!     replytoall_message_cb, NULL, NULL, GNOME_APP_PIXMAP_DATA,
!     reply_to_all_menu_xpm, 'A', 0, NULL
    },
  #define MENU_MESSAGE_FORWARD_POS 7
      /* F */
***************
*** 365,374 ****
                            GNOME_STOCK_PIXMAP_MAIL_NEW),
    GNOMEUIINFO_ITEM_STOCK (N_ ("Reply"), N_ ("Reply"),
                            replyto_message_cb,
-                           GNOME_STOCK_PIXMAP_MAIL_RPL),
-   GNOMEUIINFO_ITEM_STOCK (N_ ("Reply to all"), N_ ("Reply to all"),
-                           replytoall_message_cb,
                            GNOME_STOCK_PIXMAP_MAIL_RPL),
    GNOMEUIINFO_ITEM_STOCK (N_ ("Forward"), N_ ("Forward"),
                            forward_message_cb,
                            GNOME_STOCK_PIXMAP_MAIL_FWD),
--- 368,377 ----
                            GNOME_STOCK_PIXMAP_MAIL_NEW),
    GNOMEUIINFO_ITEM_STOCK (N_ ("Reply"), N_ ("Reply"),
                            replyto_message_cb,
                            GNOME_STOCK_PIXMAP_MAIL_RPL),
+   GNOMEUIINFO_ITEM (N_ ("Reply to all"), N_ ("Reply to all"),
+                     replytoall_message_cb,
+                     reply_to_all_xpm),
    GNOMEUIINFO_ITEM_STOCK (N_ ("Forward"), N_ ("Forward"),
                            forward_message_cb,
                            GNOME_STOCK_PIXMAP_MAIL_FWD),
***************
*** 1391,1397 ****
     balsa_app.browse_wrap = GTK_CHECK_MENU_ITEM(widget)->active;
  
     /* redisplay current message? */
!    index = balsa_window_find_current_index(BALSA_WINDOW (data));
     if(index) 
        balsa_index_redraw_current ( BALSA_INDEX(index) );
  }
--- 1394,1400 ----
     balsa_app.browse_wrap = GTK_CHECK_MENU_ITEM(widget)->active;
  
     /* redisplay current message? */
!    index = GTK_WIDGET (balsa_window_find_current_index(BALSA_WINDOW (data)));
     if(index) 
        balsa_index_redraw_current ( BALSA_INDEX(index) );
  }
Index: main.c
===================================================================
RCS file: /cvs/gnome/balsa/src/main.c,v
retrieving revision 1.66
diff -c -r1.66 main.c
*** main.c	2000/03/26 14:59:31	1.66
--- main.c	2000/03/31 00:58:53
***************
*** 300,305 ****
--- 300,306 ----
    /* TODO: select the first one, if any is open */ 
    if(gtk_notebook_get_current_page( GTK_NOTEBOOK(balsa_app.notebook) ) >=0 ) 
       gtk_notebook_set_page( GTK_NOTEBOOK(balsa_app.notebook), 0);
+ 
    gtk_main();
  
  #ifdef BALSA_USE_THREADS
Index: pref-manager.c
===================================================================
RCS file: /cvs/gnome/balsa/src/pref-manager.c,v
retrieving revision 1.102
diff -c -r1.102 pref-manager.c
*** pref-manager.c	2000/03/28 08:00:33	1.102
--- pref-manager.c	2000/03/31 00:58:54
***************
*** 183,193 ****
  	gtk_window_set_policy (GTK_WINDOW (property_box), FALSE, FALSE, FALSE);
  
          gnome_dialog_set_parent(GNOME_DIALOG(property_box), GTK_WINDOW(active_win));
! 
! 
          
! 
! 
  	page = create_identity_page();
          gnome_property_box_append_page (GNOME_PROPERTY_BOX (property_box), GTK_WIDGET (page), gtk_label_new (_ ("Identity")) );
  
--- 183,191 ----
  	gtk_window_set_policy (GTK_WINDOW (property_box), FALSE, FALSE, FALSE);
  
          gnome_dialog_set_parent(GNOME_DIALOG(property_box), GTK_WINDOW(active_win));
!         gtk_object_set_data (GTK_OBJECT (property_box), "balsawindow", (gpointer) active_win);
          
!         /* Create the pages */
  	page = create_identity_page();
          gnome_property_box_append_page (GNOME_PROPERTY_BOX (property_box), GTK_WIDGET (page), gtk_label_new (_ ("Identity")) );
  
***************
*** 362,367 ****
--- 360,366 ----
  apply_prefs (GnomePropertyBox* pbox, gint page_num)
  {
  	gint i;
+         GtkWidget *balsa_window;
  
          if (page_num != -1)
                  return;
***************
*** 483,489 ****
  	 */
  	config_global_save ();
          balsa_mblist_redraw (balsa_app.mblist);
!         balsa_window_refresh (BALSA_WINDOW (GTK_WIDGET (pbox)->parent));
  }
  
  
--- 482,489 ----
  	 */
  	config_global_save ();
          balsa_mblist_redraw (balsa_app.mblist);
!         balsa_window = GTK_WIDGET (gtk_object_get_data (GTK_OBJECT (pbox), "balsawindow"));
!         balsa_window_refresh (BALSA_WINDOW (balsa_window));
  }
  
  
=== Exit status: 1

reply_to_all.xpm

reply_to_all_menu.xpm

PGP signature



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]