[Anjuta-list] Re: [PATCH] Re: [scintilla] Autocompletion lists with images (VC style)

[Biswapesh Chattopadhyay <biswapesh_chatterjee tcscal co in>]

On Thu, 2002-11-21 at 18:41, Neil Hodgson wrote:
> 
> 
> Biswapesh Chattopadhyay:
> 
> > As promised, here is a cleaned up patch. I've also fixed a couple of
> > memory leaks in PropSet.cxx which are not strictly related.
> 
>    OK, well I cleared up a foreach over an often null pointer in the
> ListBox
> destructor :-)

Silly me ;-)

> 
> > Only the
> > files in scintilla/directory are Scintilla related - rest is for Anjuta.
> > I hope this can go into the Scintilla tree without too many major
> > changes.
> 
>    Its in with some warnings fixed and reindented. Ther eis still a warning
> for the g_return_if_fail(xpm_data); in ListBox::SetTypeXpm when compiling
> on
> Windows with MSVC:
> PlatGTK.cxx(1376) : warning C4127: conditional expression is constant
>    I don't know if this is a real problem.

Probably not - as Naba explained.

> 
>    It appears this only allows for the array of lines format you get from
> #including XPM files - the XPM class in scintilla/src/LineMarker.cxx can
> cope with both this and the file form. Its easy to go from the file form to
> the array of lines and it would be helpful to either offer two entry points
> or notice that the argument points to "/* X" which is the first 32 bits of
> the "/* XPM */" header and treat it as the file form otherwise as the lines
> form.

Won't it be better if we support both xpm_data and xpm_file (in
different functions of course). We'd prefer to pass the file name as
parameter for Anjuta for example. Can you elaborate a bit on why this is
not a good idea from security P.O.V ?

> 
>    Available from CVS and from
> http://www.scintilla.org/scite.zip
> 

Thanks a lot.

Rgds,
Biswa.

>    Neil
> 
>