[anjuta-devel] Fwd: Re: Another patch

[Sébastien Granjoux <seb sfo free fr>]

Hi,

Le 04/02/2011 18:50, Nancí de Brito Bonfim a écrit :
> I've removed the functions related to the MkpRoot and put all of the
> other unused functions inside if 0 blocks. It compiles and run.
> I also removed the base.state from the MkpTarget, so it won't appear in
> the dialog of adding new files to the project. This dialog was crashing
> Anjuta and nothing was added, anyway.
> To add a new file someone would have to edit the makefile, right?

Yes.


> As a read-only backend I think it's working fine.

Ok.


> Here is the patch, with the #if 0 blocks and with the former whitespace
> bugs cleaned up.

Ok, that's fine for me. I have applied the patch, it compiles and I get
something in the project view.


> I haven't removed those functions because I don't know whether they will
> be useful soon or if they are deprecated.

I think it's better to remove useless code when using a version control
system. It makes the code easier to read which is important when several
person works on it. You can always get back the old code looking at the
history of the files. Anyway, it's difficult for you to know what is
useful and what is not needed anymore, so I will remove this code myself.

Then, now that the makefile backend is compiling again. I have seen that
the automatic reload of the project when the makefile is changed doesn't
work. I will fix it.

Finally, I will try to check if I cannot improve it a bit because it
doesn't find most targets and no source files on the anjuta makefile
project template.



On your side, I think your work on the makefile backend is complete.
Thanks for taking care of it. So I will close the bug
https://bugzilla.gnome.org/show_bug.cgi?id=637981. It has been more
difficult than I have expected, I hope you haven't found it too hard.

So, now you have to select another task in the list that I have sent you
a few months ago. If you want you can look at more recent bugs in anjuta
bug list here:
https://bugzilla.gnome.org/buglist.cgi?query=product%3Aanjuta
Ask me if you need more details about some of these tasks.



Regards,

Sébastien