Re: [Tracker] compiler warnings

[Laurent Aguerreche <laurent aguerreche free fr>]

Le mardi 31 juillet 2007 Ã 20:59 +1000, tpgww onepost net a Ãcrit :
> On Tue, 31 Jul 2007 00:22:13 +0200
> Laurent Aguerreche <laurent aguerreche free fr> wrote:
>
> > Le mardi 31 juillet 2007 Ã 08:14 +1000, tpgww onepost net a Ãcrit :
> > > I just built tracker svn (734, from yesterday) and, among the many compiler-warnings generated, I see a 
> > > few that really should be investigated and dealt with one way or another:
> > >
> > > trackerd.c:2349: warning: ignoring return value of 'nice', declared with attribute warn_unused_result
> > > trackerd.c:1021: warning: 'list' may be used uninitialized in this function
> > > tracker-db-sqlite.c:462: warning: ignoring return value of 'fgets', declared with attribute 
> > > warn_unused_result
> > > tracker-db-sqlite.c:1189: warning: ignoring return value of 'link', declared with attribute 
> > > warn_unused_result
> > > tracker-db-email.c:412: warning: 'mbox_id' may be used uninitialized in this function
> > > tracker-dbus-search.c:901: warning: 'winner_dist' may be used uninitialized in this function
> > > tracker-utils.c:3441: warning: ignoring return value of 'nice', declared with attribute 
> > > warn_unused_result
> > > tracker-extract.c:212: warning: ignoring return value of 'nice', declared with attribute 
> > > warn_unused_result
> > > tracker-extract-ps.c:101: warning: ignoring return value of 'getline', declared with attribute 
> > > warn_unused_result
> > > tracker-extract-ps.c:139: warning: ignoring return value of 'getline', declared with attribute 
> > > warn_unused_result
> > > tracker-extract-abw.c:35: warning: ignoring return value of 'getline', declared with attribute 
> > > warn_unused_result
> > > tracker-extract-abw.c:62: warning: ignoring return value of 'getline', declared with attribute 
> > > warn_unused_result
> > > tracker-extract-gstreamer.c:233: warning: 'message' is used uninitialized in this function
> >
> > I do not have any warnings about "warn_unused_result".
> >
> > What compiler do you use? What version? What compiler flags?
>
> gcc 4.2.1
>
> -O2 -g -pipe -Wp -D_FORTIFY_SOURCE=2 -fstack-protector --param=ssp-buffer-size=4 -fexceptions 
> -fomit-frame-pointer -march=i586 -mtune=generic -fasynchronous-unwind-tables (these are defaults for 
> mandriva's rpmbuild)
>
> > What is your platform? Linux (What distribution and version? Is it up to
> > date?)? Unix (vendor?)?
>
> mandriva cooker i586 (not necessarily completely fresh, but certainly no package older than in the last 
> official release)

Warnings come from "-D_FORTIFY_SOURCE=2". With this parameter, functions
that use "warn_unused_result" will make GCC scream if we do not test
their return value. So I rewrote some functions in tracker-extract.
Some of them are really not important, like for "nice()" since its
returned value does not indicate if something went wrong on recent
glibc...


The patch I'm providing also contain fixes for dates in
tracker-extract-ps.c + code cleanups (I did some code refactoring for
dates).


Jamie, I do not have problem with dates and MSOffice files nor PDF, so
can you test again?

I do not have PNG files with CreationTime tag so is there somebody who
can test tracker-extract on such a file?


Laurent.

> Regards
> Tom

Attachment: work-on-tracker-extract.diff.tar.gz
Description: application/compressed-tar

Attachment: signature.asc
Description: Ceci est une partie de message =?ISO-8859-1?Q?num=E9riquement?= =?ISO-8859-1?Q?_sign=E9e?=