Re: Freeze break request for gnome-shell




I'm nervous about this one for three reasons:

* It's gjs, so any subtle flaw in this changeset could cause entire functions to be skipped over * We're two days before the tarball deadline, so there's really no time left to notice if any such flaws were to sneak in
* It's also drag-and-drop code, which is tricky to get right

I would have given +1 to this if requested earlier this week, but at this point I'll be quite cautious and suggest committing immediately after 3.30.0, so that it has a couple weeks to bake it git before 3.30.1, just in case.

I'm happy to see the invalid access warnings will be fixed. Almost as happy as I would be to see tweener fixes. :P

Michael



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]