Re: HC Freeze break

["Elijah Newren" <newren gmail com>]

On 9/16/07, Srinivasa Ragavan <sragavan novell com> wrote:
> Hello Guys,
>
> I was just preparing my build machine for the final release and disabled
> DEVELOPMENT warning in the configure.in that pops up for Evolution
> during the unstable releases, I figured out that when I disable it there
> is a build break in Evolution/shell/main.c
>
> The GConfClient variable 'client' defined for showing the development
> warning is now used outside the #ifdefs also and so it gives a undefined
> variable 'client' error. This break didn't popup till today, since the
> DEVELOPMENT was enabled and it was working fine. I disabled it for the
> final release to see it.
>
> The attached patch would fix that break and I have tested it well (I
> couldn't have build Evolution otherwise) as well as it doesn't introduce
> any new issues and works fine.
>
> The release planning wiki for Hard code freeze says: Simple build fixes
> are, of course, allowed without asking.
>
> I wasn't sure if this is that category or not, felt better to ask it
> anyways.

I count it as a build fix (if others disagree, then count that as one
of two approvals).  :-)

Cheers,
Elijah