Re: kernel cmdline - allow duplicate keys



On Thu, Jul 31, 2014 at 01:39:03PM -0400, Colin Walters wrote:
On Wed, Jul 30, 2014, at 11:13 PM, Dusty Mabe wrote:
Hi,

It seems from _ostree_kernel_args_replace_take() in
ot-admin-builtin-deploy.c that
we have adopted the philosophy that more than one option on the kernel
command line
with the same key is not useful (i.e. foo=val1 foo=val2). 

This is
https://bugzilla.gnome.org/show_bug.cgi?id=721136
right?

Looks similar.. 

Basically if I specify --karg-proc-cmdline and there are existing duplicate keys 
in the kernel command line (which is valid) then those should survive and not get
squashed. My previous email demostrated that this doesn't seem to happen. In my
case I end up with a system that doesn't boot.

I get that this is a complicated problem because in the case where you are merging
configuration it would make things much easier if duplicate keys aren't supported.

Dusty


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]