Re: [PATCH] mbm plugin: send enap=0 on disable

[Dan Williams <dcbw redhat com>]

On Fri, 2009-11-20 at 18:53 +0100, Pablo Martí Gamboa wrote:
> 
> 
> 2009/11/20 Torgny Johansson <torgny johansson gmail com>
>         Hi!
>         
>         This patch makes the mbm plugin send at*enap=0 when disable is
>         called.
>         
>         Currently enap=0 is only sent when disconnect is called which
>         I don't see happening. That causes enap to stay
>         connected even if the user selects disconnect from nm-applet.
>         
>         I'm not sure if this is the intended behaviour or if the bug
>         is that disconnect isn't being called though...
> 
> 
> Hi Torgny,
> 
> 
> NM 0.8 sends "Enable(false)" instead of "Disconnect()", assuming that
> it should disconnect the device too, although as you well know, that
> is not always the case. This is a deviation from the original
> ModemManager spec, Dan Williams acknowledged this problem and it
> should be fixed soon.

Yes; I haven't been able to get back to the 3G side of things for a week
or so but this is still on the table to get fixed.


On that note Pablo, would you mind if I added an "Enabled" (type bool)
property to the org.freedesktop.ModemManager.Modem interface to indicate
the current enablement state?

The reason I want to do this is because in the multi-modem-user case
where NM should not be disabling the device, we still need a mechanism
to allow users to do that to save power or whatever if their laptop does
not support rfkill of the device.  For NetworkManager, I'd put a "Enable
Mobile Broadband" checkbox into the right-click menu of nm-applet, just
like the Enable Wireless checkbox is there.  This checkbox would reflect
the state of each modem's Enabled property.  If the user unchecked the
box, the applet would direct NetworkManager to disable all 3G devices
using Enable(false), while simply choosing Disconnect in the menu would
direct NM to call Disconnect() as we've previously discussed.

Dan