Re: Please review Open Location patch

[Alexander Larsson <alexl redhat com>]

On Tue, 2010-01-26 at 17:18 +0100, Marcus Carlson wrote:
> Alex (or anyone else),
> 
> Please review the last patch in the bugreport at [1] and I'll find
> some 
> time to fix it if needed.

I don't think you're correctly handling the case where we start loading
another location before the callback has been called, or if the window
is closed early. You need to handle this in end_location_change() if
there is a callback set.


-- 
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
       alexl redhat com            alexander larsson gmail com 
He's a time-tossed small-town card sharp who knows the secret of the alien 
invasion. She's a radical psychic research scientist with a birthmark shaped 
like Liberty's torch. They fight crime!