gtksourceviewmm issues.



Hi,

I recently tried to turn gtksourceviewmm-3.0 into some sensible shape
and I maybe partially succeeded, that is - all TODOs in source files are
handled, completion stuff seems to work.

However there are several issues I'm leaving as they are for now:

---
1. Search test (in tests/search directory) segfaults in line 53:

get_vbox ()->pack_start (*m_hbox) ;

To reproduce it, just run the test and do Edit->Search.
---

---
2. Basic test (in tests/basic) aborts with failed assertion:

Gtk:ERROR:gtktextview.c:3002:gtk_text_view_finalize: assertion failed:
(priv->buffer == NULL)

To reproduce it just run the test in hit the X in the corner of title
bar to quit the application. In general this assertion pops when
everything is being destroyed.
---

---
3. Backport changes to 2.10 - when fixing completion stuff in 3.0 API I
realized that this part is unusable in 2.0 - changes wrt. reference
counting, completion test and conversions cleanup should be backported.
And probably all TODO comments need to be removed.
---

---
4. gtksourceview vs. Gsv - current namespace name (gtksourceview) is
awkward and inconsistent with mm modules. I would rename it to Gsv. And
maybe add a compat header file containing a line:

'namespace gtksourceview = Gsv;'

What do you think?
---


I'm not sure about the first two - maybe they are results of changes in
Gtk+/gtkmm and needs to be corrected or maybe I'm just stupid and can't
see obvious mistakes. Or maybe my jhbuild environment is screwed up.
That way or another - I'm leaving it for a while (a month or two), since
I have to do some other "away from programming keyboard" stuff, sorry.
Feel free to push patches fixing above issues (maybe without 4th one) or
file bugs in bugzilla with patches - I'll push them if they are all
right.

Thanks,
Krzesimir



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]