Re: [gtk-vnc-devel] [patch] solaris ld does not support --version-script

[Halton Huo <Halton Huo Sun COM>]

According a gnome-keyring bug 462349, you could have a look the patch here.

 I remake the patch, hope it is compatible for Linux and Solaris as well.


On Fri, 2007-10-26 at 08:59 -0500, Anthony Liguori wrote:
> Halton Huo wrote:
> > Hi there,
> >
> > I'm trying to build gtk-vnc trunk code on Solaris, but met ld fail,
> > it is because ld on Solaris does not support --version-script, can we 
> > just remove it?
> >
> > Attach the patch here, do not know it is a right one.
>
> I agree with Dan re: disabling conditionally on Solaris.
>
> Please update this patch along with the CPP fix patch and resend the 
> whole series.  Please use hg export to generate the patches too so that 
> they contain a proper manifest and username.
I'm new for Mercurial, I generate the patch using 'hg diff'.
When I run 'hg export'  it tells me
$hg export
abort: export requires at least one changeset

> Regards,
>
> Anthony Liguori



diff -r d6f1a50dbb0b src/Makefile.am
--- a/src/Makefile.am	Sun Oct 21 17:11:07 2007 -0300
+++ b/src/Makefile.am	Sun Oct 28 12:05:09 2007 +0800
@@ -7,7 +7,7 @@ libgtk_vnc_1_0_la_CFLAGS = @GTK_CFLAGS@ 
 libgtk_vnc_1_0_la_CFLAGS = @GTK_CFLAGS@ @GNUTLS_CFLAGS@ @WARNING_CFLAGS@ \
                            -DSYSCONFDIR=\""$(sysconfdir)"\" \
                            @DEBUG_CFLAGS@
-libgtk_vnc_1_0_la_LDFLAGS = -Wl,--version-script=$(srcdir)/libgtk-vnc_sym.version \
+libgtk_vnc_1_0_la_LDFLAGS = -export-symbols-regex 'vnc_display_' 'gvnc_' 'coroutine_' \
                             -version-info 0:1:0
 
 gtk_vnc_includedir = $(includedir)/gtk-vnc-1.0/