On Wed, 2005-02-09 at 22:29 +0200, Victor Osadci wrote: > Adam, nice job, it looks really good! Thanks. I didn't really do much to it except make it resize nicely :). Thank Reinout, and clarkbw's friend (who made the original Evince site). > I have a few suggestions to make it work better with some browsers and > also some improvements (maybe). > > The files are attached and are based on > http://www.cs.vu.nl/~reinout/epiphany.xhtml . > * I removed some duplicate spacing and added a space before self > closing tags, so that <br/> becomes <br />. This helps some non > xhtml browsers understand the code better. Technically, this isn't a problem. XHTML 1.1 is probably beyond "non-xhtml" browsers (except IE, through blind luck, but it doesn't have the " />" problem. So... whatever floats your boat :). (I've never actually *found* a browser which renders " />" properly but not "/>". I wish the W3C would say which ones these are.... Or is my recollection of IE's suckiness not quite complete?) Oh crap, I just noticed something! Reinout: please remove the <meta> line completely. It's not necessary for XHTML, and in our particular case it's wrong, since it says "text/html"! Anyway, proof that we don't want <meta>: http://www.w3.org/TR/xhtml-media-types/#application-xml > * Made the top Ephy logo clickable!. This brings up another thing I've been wondering about: we *will* be using relative URLs in the final pages, right? ;) > * In the css the left and right bars use "14em" and "17.5em", > which makes the content overlap when using bigger fonts in the > browser. This seams to go away when using percentages. Hrm. A bug in the rendering engine? I don't understand why that behavior occurs. Percentages are just as good, maybe better but I'm no graphic designer. Only, I think now the margin between the left and right divs can't be exactly the same as the page side margins (unless all horizontal positioning and margins use percentages...). Another possible fix would be to make div.right have text-size: 100%, and make div.right>div have text-size: 80%. Then we could specify sizes the "right" way. That's what I should have done last night, but I didn't think of it. (CSS really doesn't make things easy....) > * Also, I quite like the way it looks when the left side is > aligned on both sides... What do you guys think. I dunno. I've always learned not to use full-justify except in newspaper columns. But I'm *definitely* no graphic designer. > * Reinout, I'm curious, how do you handle the mime type? Are you > sending "application/xhtml+xml" to all browsers as the XHTML1.1 > standard says, or give older browsers "text/html" ? (As followup to one of Reinout's future posts): Google on this and you'll find lots of ways to serve text/html to IE. http://www.xml.com/pub/a/2003/03/19/dive-into-xml.html explains it quite thouroughly; scroll way down to the .htaccess file part. Or the PHP part. While it would be kind of nice to "make a statement" about standards-compliance, I think it comes off as arrogant. I mean, hell, I don't even do it on my *personal* web pages. > * Adam, any particular reason to specify the width and height of > the epiphany screen shot (screenshot.png)? It sometimes forces > browsers to show a big empty space if the image is not shown. I didn't do it! I didn't touch any of the content. > Try it in epiphany with the option to use the theme colours set. Hey, that's cool -- it actually looks good :). > OK, I'm done. Do you think this will "make this web a better place to > live"? Feel free to throw something at me if you don't ;-) . Yeah! Fixing up the 'web -- one page at a time. (However, I must admit the existing Epiphany page has no real faults; it's just that this new one is prettier.) Anyway, thanks for caring :). -- Adam Hooper <adamh densi com>
Attachment:
signature.asc
Description: This is a digitally signed message part