[Epiphany] Re: Security prompt dialogs

[Crispin Flowerday <gnome flowerday cx>]

> I think there was at least three better ways to solve the issue:
> 
> - Convince Owen to support hig dialogs in gtk+ in some way
> - Hack a new implementation in egg, either using the same api or
> changing it if necessary. It could have gone in gtk later (3.0 or when
> Owen would feel comfortable).
> - Make glade support higgy dialogs

I don't think that making glade support higgy dialogs would help here, I
did implement them all as glade dialogs originally, and it was just a
waste of time as they were so small, using gtk directly was much better.

We (well tko) wrote the hig-alert class to help creating dialogs with
proper HIG'y spacing. Almost all dialogs I have seen in applications,
(and I am afraid to say, even epiphany) don't have the correct spacing.
By using this class, it makes it easy to create dialogs that are
correct.

I agree a better solution would be for Gtk to support hig alerts itself,
but until then, I make no apologies for using it :)

> Anyway I think I have these possibilities to deal with sharing problem.
> 
> - Convince galeon people to use gtk at least for mozilla prompts until
> there is a better solution (or to work on it ;)
> - Use their hig dialog as private in mozilla/
> - Modify their code and lose the ability to sync

I would like to keep the implementations as close possible, If you have
really strong objections to using the hig-alert class, I will re-work
them as plain gtk, but it really is quite a nice class :)

> Another thing to keep in consideration is the possibility that the two
> implementations will fork ui wise in the future (the work we are doing
> on security design could convince us to make changes).

Its a possibilty in the future, but it would be nice to keep them the
same at least for the moment.

BTW, if anyone has any text issues with them, then please CC me on any
discussions.

Crispin

PS. Please try and keep me in the CC list, I am not on the epiphany
mailing list.