Re: [easytag] : build fails by src / log.c ecause of g_strdup_vprintf

[David King <amigadave amigadave com>]

Hi Hugu

Please email the easytag-list gnome org mailing list in future, rather 
than me directly.

On 2013-10-17 18:50, Hugo Machefer <hugo machefer gmail com> wrote:
> Allow me to request a favoir by logs collected from
> http://www.mail-archive.com/freebsd-pkg-fallout freebsd org/msg09761.html
>
> Reminder :
>
> src/log.c:258:31: error: format string is not a string literal
> [-Werror,-Wformat-nonliteral]
>    string = g_strdup_vprintf(format, args);
>                              ^~~~~~
>
>
> How did you solve this (recent) issue ?

The code has not changed in quite a while, but Log_Print() was recently 
annotated with G_GNUC_PRINTF (2, 3):

https://git.gnome.org/browse/easytag/commit/?id=6fa1490e92aa887799ad87b2cdf2475845ea7be0

After this, two instances where Log_Print() was called incorrectly were 
fixed (which is probably what your compiler warned about):

https://git.gnome.org/browse/easytag/commit/?id=db1580b731ee5075ee2f3ea6b6f1a082c09bd4de

You should be able to apply either the latter fix or both fixes to solve 
the problem. I tested the fixes with both Clang and GCC, so they should 
work fine for FreeBSD.

--
http://amigadave.com/

Attachment: signature.asc
Description: Digital signature