[gnome-builder/gnome-builder-43] libide/editor: don't disable editability during async operation



commit 51e9b041ec349e035ed794f84ec3945e25aeb6e1
Author: Christian Hergert <chergert redhat com>
Date:   Wed Sep 21 15:51:45 2022 -0700

    libide/editor: don't disable editability during async operation
    
    As it can break input methods currently.

 src/libide/editor/ide-editor-page.c | 5 +++++
 1 file changed, 5 insertions(+)
---
diff --git a/src/libide/editor/ide-editor-page.c b/src/libide/editor/ide-editor-page.c
index a7ec47817..863989beb 100644
--- a/src/libide/editor/ide-editor-page.c
+++ b/src/libide/editor/ide-editor-page.c
@@ -528,7 +528,9 @@ format_selection_cb (GObject      *object,
                            _("Failed to format selection: %s"),
                            error->message);
 
+#if 0
   gtk_text_view_set_editable (GTK_TEXT_VIEW (self->view), TRUE);
+#endif
 
   IDE_EXIT;
 }
@@ -556,8 +558,11 @@ format_action (GtkWidget  *widget,
   ide_formatter_options_set_tab_width (options, tab_width);
   ide_formatter_options_set_insert_spaces (options, insert_spaces_instead_of_tabs);
 
+#if 0
   /* Disable editing while we format */
+  /* BUG: we can't currently do this because it breaks input methods */
   gtk_text_view_set_editable (GTK_TEXT_VIEW (self->view), FALSE);
+#endif
 
   ide_buffer_format_selection_async (self->buffer,
                                      options,


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]