[glib: 4/6] gdesktopappinfo: Unref the GDBus call results




commit 221f22b6e18fdd306e676e28a79afd3697bddd03
Author: Marco Trevisan (TreviƱo) <mail 3v1n0 net>
Date:   Fri Sep 2 20:38:46 2022 +0200

    gdesktopappinfo: Unref the GDBus call results
    
    On our GDBus call callback wrapper we were completing the gdbus call but
    ignoring the returned value, that was always leaked.
    
    Fix this.
    
    Helps with: https://gitlab.gnome.org/GNOME/glib/-/issues/333

 gio/gdesktopappinfo.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)
---
diff --git a/gio/gdesktopappinfo.c b/gio/gdesktopappinfo.c
index af2311ca52..52d308f540 100644
--- a/gio/gdesktopappinfo.c
+++ b/gio/gdesktopappinfo.c
@@ -3283,15 +3283,19 @@ launch_uris_with_dbus_cb (GObject      *object,
 {
   GTask *task = G_TASK (user_data);
   GError *local_error = NULL;
+  GVariant *ret;
 
-  g_dbus_connection_call_finish (G_DBUS_CONNECTION (object), result, &local_error);
+  ret = g_dbus_connection_call_finish (G_DBUS_CONNECTION (object), result, &local_error);
   if (local_error != NULL)
     {
       g_dbus_error_strip_remote_error (local_error);
       g_task_return_error (task, g_steal_pointer (&local_error));
     }
   else
-    g_task_return_boolean (task, TRUE);
+    {
+      g_task_return_boolean (task, TRUE);
+      g_variant_unref (ret);
+    }
 
   g_object_unref (task);
 }


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]