[libgit2-glib/wip/adwait/commit_with_signature: 2/2] oid is modified by function




commit 32dcd13e39478bc383cb38b9722f0a0143a78f4c
Author: Alberto Fanjul <albertofanjul gmail com>
Date:   Thu Oct 6 09:13:44 2022 +0200

    oid is modified by function

 libgit2-glib/ggit-repository.c | 7 ++++---
 libgit2-glib/ggit-repository.h | 1 +
 2 files changed, 5 insertions(+), 3 deletions(-)
---
diff --git a/libgit2-glib/ggit-repository.c b/libgit2-glib/ggit-repository.c
index cd3740f..a652049 100644
--- a/libgit2-glib/ggit-repository.c
+++ b/libgit2-glib/ggit-repository.c
@@ -3283,19 +3283,20 @@ ggit_repository_create_commit_from_ids (GgitRepository  *repository,
  */
 GgitOId *
 ggit_repository_create_commit_with_signature (GgitRepository  *repository,
+                                              GgitOId         *oid,
                                               const gchar     *commit_content,
                                               const gchar     *signature,
                                               const gchar     *signature_field,
                                               GError         **error)
 {
        gint ret;
-       git_oid oid;
 
+       g_return_val_if_fail (oid != NULL, NULL);
        g_return_val_if_fail (GGIT_IS_REPOSITORY (repository), NULL);
        g_return_val_if_fail (commit_content != NULL, NULL);
        g_return_val_if_fail (error == NULL || *error == NULL, NULL);
 
-       ret = git_commit_create_with_signature (&oid,
+       ret = git_commit_create_with_signature (_ggit_oid_get_oid (oid),
                                                _ggit_native_get (repository),
                                                commit_content,
                                                signature,
@@ -3307,7 +3308,7 @@ ggit_repository_create_commit_with_signature (GgitRepository  *repository,
                return NULL;
        }
 
-       return _ggit_oid_wrap (&oid);
+       return oid;
 }
 
 /**
diff --git a/libgit2-glib/ggit-repository.h b/libgit2-glib/ggit-repository.h
index 20dc064..36a8914 100644
--- a/libgit2-glib/ggit-repository.h
+++ b/libgit2-glib/ggit-repository.h
@@ -163,6 +163,7 @@ GgitOId            *ggit_repository_create_commit_from_ids (
 
 GgitOId            *ggit_repository_create_commit_with_signature (
                                                        GgitRepository  *repository,
+                                                       GgitOId        *oid,
                                                        const gchar     *commit_content,
                                                        const gchar     *signature,
                                                        const gchar     *signature_field,


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]