[gnome-control-center/wip/kate/improve-datetime] firmware-security: improve datetime format parsing




commit 83cd4108496db2c0fb2c9e97a188dd73be6794e0
Author: Kate Hsuan <hpa redhat com>
Date:   Wed Aug 31 10:41:58 2022 +0800

    firmware-security: improve datetime format parsing
    
    Showing the datetime string using cc_util_get_smart_date_time().

 panels/common/cc-util.c                               | 7 ++++++-
 panels/firmware-security/cc-firmware-security-panel.c | 2 +-
 2 files changed, 7 insertions(+), 2 deletions(-)
---
diff --git a/panels/common/cc-util.c b/panels/common/cc-util.c
index cdad785c4..731b4544e 100644
--- a/panels/common/cc-util.c
+++ b/panels/common/cc-util.c
@@ -149,12 +149,17 @@ char *
 cc_util_get_smart_date_time (GDateTime *date)
 {
   g_autofree gchar *date_str = NULL;
+  g_autofree gchar *smart_date = NULL;
 
   if (date == NULL)
     return NULL;
 
+  smart_date = cc_util_get_smart_date (date);
   date_str = g_date_time_format (date, "\%X");
-  return g_strdup_printf ("%s, %s", cc_util_get_smart_date (date), date_str);
+  /* TRANSLATORS: This is the datetime format in the style of
+     "Aug 1, 10:10:10 PM", "Feb 24, 2013, 10:10:10 PM", "Today, 10:10:10 AM",
+     and "Yesterday, 10:10:10 AM" */
+  return g_strdup_printf ("%1$s, %2$s", smart_date, date_str);
 }
 
 /* Copied from src/plugins/properties/bacon-video-widget-properties.c
diff --git a/panels/firmware-security/cc-firmware-security-panel.c 
b/panels/firmware-security/cc-firmware-security-panel.c
index d48e7abc1..80303489f 100644
--- a/panels/firmware-security/cc-firmware-security-panel.c
+++ b/panels/firmware-security/cc-firmware-security-panel.c
@@ -184,7 +184,7 @@ parse_event_variant_iter (CcfirmwareSecurityPanel *self,
 
   /* build new row */
   date = g_date_time_new_from_unix_local (attr->timestamp);
-  date_string = g_date_time_format (date, "\%F \%H:\%m:\%S");
+  date_string = cc_util_get_smart_date_time (date);
 
   row = adw_expander_row_new ();
   if (attr->flags & FWUPD_SECURITY_ATTR_FLAG_SUCCESS)


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]