[gnome-shell-extensions] window-list: Fix cleaning up signal on removal



commit a51145f9dbbd7d0ae75de21dde6883f0ca6797b3
Author: Florian Müllner <fmuellner gnome org>
Date:   Tue Mar 29 17:06:40 2022 +0200

    window-list: Fix cleaning up signal on removal
    
    The map uses windows as key, so trying to remove the handler ID
    will leave stray windows/signals.
    
    Spotted by Ron Yorston.
    
    Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell-extensions/-/merge_requests/225>

 extensions/window-list/extension.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
---
diff --git a/extensions/window-list/extension.js b/extensions/window-list/extension.js
index f7e0a41..0ca6729 100644
--- a/extensions/window-list/extension.js
+++ b/extensions/window-list/extension.js
@@ -998,7 +998,7 @@ class WindowList extends St.Widget {
         const id = this._windowSignals.get(win);
         if (id)
             win.disconnect(id);
-        this._windowSignals.delete(id);
+        this._windowSignals.delete(win);
 
         let children = this._windowList.get_children();
         let child = children.find(c => c.metaWindow === win);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]