[orca] Web: Don't return early when generating ancestors for table descendants



commit 43b0581b630a771010da9a4de01f48f91fdf0f1d
Author: Joanmarie Diggs <jdiggs igalia com>
Date:   Thu Jun 30 13:20:27 2022 +0200

    Web: Don't return early when generating ancestors for table descendants
    
    If a user is tabbing among links inside an ARIA grid, we were not
    speaking the headers and positions of column headers. In order to fix
    this completely, we need to do two things: 1) Generate ancestors and
    2) Adjust what information gets generated for the cell information.
    The second might have undesired side effects, so the changes are being
    split. This commit only addresses the first.
    
    See issue #253

 src/orca/scripts/web/speech_generator.py | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)
---
diff --git a/src/orca/scripts/web/speech_generator.py b/src/orca/scripts/web/speech_generator.py
index ac3d45f0c..23b0f769e 100644
--- a/src/orca/scripts/web/speech_generator.py
+++ b/src/orca/scripts/web/speech_generator.py
@@ -81,10 +81,11 @@ class SpeechGenerator(speech_generator.SpeechGenerator):
             if priorDoc != doc and not self._script.utilities.getDocumentForObject(doc):
                 result = [super()._generateName(doc)]
 
-        if self._script.utilities.isLink(obj) \
-           or self._script.utilities.isLandmark(obj) \
-           or self._script.utilities.isMath(obj) \
-           or obj.getRole() in [pyatspi.ROLE_TOOL_TIP, pyatspi.ROLE_STATUS_BAR]:
+        if not self._script.utilities.getTable(obj) \
+           and (self._script.utilities.isLink(obj) \
+                or self._script.utilities.isLandmark(obj) \
+                or self._script.utilities.isMath(obj) \
+                or obj.getRole() in [pyatspi.ROLE_TOOL_TIP, pyatspi.ROLE_STATUS_BAR]):
             return result
 
         args['stopAtRoles'] = [pyatspi.ROLE_DOCUMENT_WEB,


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]