[glib-networking/mcatanzaro/proxy-validation: 1/2] gproxyresolvergnome: correct usage of GSimpleProxyResolver APIs




commit 7a90304073a2775d0dbee06f34e8b309796d971e
Author: Michael Catanzaro <mcatanzaro redhat com>
Date:   Thu Jun 9 16:25:42 2022 -0500

    gproxyresolvergnome: correct usage of GSimpleProxyResolver APIs
    
    GSimpleProxyResolver was accepting NULL for default_proxy, but this is
    no longer allowed since glib!2742. Well, it was never supposed to be
    allowed because the parameter was not nullable, but now it's *really*
    not allowed.

 proxy/gnome/gproxyresolvergnome.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
---
diff --git a/proxy/gnome/gproxyresolvergnome.c b/proxy/gnome/gproxyresolvergnome.c
index 91c9d8f1..f2097460 100644
--- a/proxy/gnome/gproxyresolvergnome.c
+++ b/proxy/gnome/gproxyresolvergnome.c
@@ -154,7 +154,7 @@ g_proxy_resolver_gnome_init (GProxyResolverGnome *resolver)
 {
   g_mutex_init (&resolver->lock);
 
-  resolver->base_resolver = g_simple_proxy_resolver_new (NULL, NULL);
+  resolver->base_resolver = g_simple_proxy_resolver_new ("direct://", NULL);
 
   resolver->proxy_settings = g_settings_new (GNOME_PROXY_SETTINGS_SCHEMA);
   g_signal_connect (resolver->proxy_settings, "changed",
@@ -191,7 +191,7 @@ update_settings (GProxyResolverGnome *resolver)
   resolver->need_update = FALSE;
 
   g_free (resolver->autoconfig_url);
-  g_simple_proxy_resolver_set_default_proxy (simple, NULL);
+  g_simple_proxy_resolver_set_default_proxy (simple, "direct://");
   g_simple_proxy_resolver_set_ignore_hosts (simple, NULL);
   g_simple_proxy_resolver_set_uri_proxy (simple, "http", NULL);
   g_simple_proxy_resolver_set_uri_proxy (simple, "https", NULL);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]