[sysprof/wip/chergert/path-resolver] elf: add note about zero inodes



commit a0de244f7ea03ad44afc8da6e6a3c6f1e8e4c6fe
Author: Christian Hergert <chergert redhat com>
Date:   Tue Sep 21 16:03:58 2021 -0700

    elf: add note about zero inodes

 src/libsysprof/sysprof-elf-symbol-resolver.c | 3 +++
 1 file changed, 3 insertions(+)
---
diff --git a/src/libsysprof/sysprof-elf-symbol-resolver.c b/src/libsysprof/sysprof-elf-symbol-resolver.c
index 516e632..1e21e74 100644
--- a/src/libsysprof/sysprof-elf-symbol-resolver.c
+++ b/src/libsysprof/sysprof-elf-symbol-resolver.c
@@ -533,6 +533,9 @@ sysprof_elf_symbol_resolver_resolve_full (SysprofElfSymbolResolver *self,
 
   g_assert (bin_file != NULL);
 
+  /* PERF_RECORD_MMAP doesn't provide an inode, so we can't rely on that
+   * until we can get PERF_RECORD_MMAP2.
+   */
   if G_UNLIKELY (map->inode && !bin_file_check_inode (bin_file, map->inode))
     {
       *name = g_strdup_printf ("%s: inode mismatch", map->filename);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]