[tracker/wip/carlosg/uri-is-parent-checks: 2/3] libtracker-data: Issue fatal g_error() if next resource ID cannot be found




commit 25d795aa6a230fa5faa3fce9835fa181bddabe12
Author: Carlos Garnacho <carlosg gnome org>
Date:   Sat Oct 31 15:52:33 2020 +0100

    libtracker-data: Issue fatal g_error() if next resource ID cannot be found
    
    This breaks fundamental assumptions (e.g. that getting a next resource ID is
    not failable), breaks even further if those resources don't get the specified
    ID.
    
    It is preferrable to hard error altogether, and let users report the
    backtrace/error.
    
    Related: https://gitlab.gnome.org/GNOME/tracker-miners/-/issues/150

 src/libtracker-data/tracker-data-update.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
---
diff --git a/src/libtracker-data/tracker-data-update.c b/src/libtracker-data/tracker-data-update.c
index 31c880c3e..3ce1b7897 100644
--- a/src/libtracker-data/tracker-data-update.c
+++ b/src/libtracker-data/tracker-data-update.c
@@ -804,7 +804,7 @@ ensure_resource_id (TrackerData *data,
                }
 
                if (error) {
-                       g_critical ("Could not ensure resource existence: %s", error->message);
+                       g_error ("Could not ensure resource existence: %s", error->message);
                        g_error_free (error);
                }
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]