[evolution-data-server] I#198 - goa: Doesn't set ESourceAuthentication::is-external properly

[Milan Crha <mcrha src gnome org>]

commit 127dde9233bb62d59ca486a5610c19fde9ed92c7
Author: Milan Crha <mcrha redhat com>
Date:   Thu Mar 5 17:32:44 2020 +0100

    I#198 - goa: Doesn't set ESourceAuthentication::is-external properly
    
    Closes https://gitlab.gnome.org/GNOME/evolution-data-server/issues/198

 src/modules/gnome-online-accounts/module-gnome-online-accounts.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)
---
diff --git a/src/modules/gnome-online-accounts/module-gnome-online-accounts.c 
b/src/modules/gnome-online-accounts/module-gnome-online-accounts.c
index 0c1105813..3f09a5f23 100644
--- a/src/modules/gnome-online-accounts/module-gnome-online-accounts.c
+++ b/src/modules/gnome-online-accounts/module-gnome-online-accounts.c
@@ -539,9 +539,6 @@ gnome_online_accounts_config_oauth (EGnomeOnlineAccounts *extension,
        extension_name = E_SOURCE_EXTENSION_AUTHENTICATION;
        source_extension = e_source_get_extension (source, extension_name);
 
-       e_source_authentication_set_is_external (
-               E_SOURCE_AUTHENTICATION (source_extension),
-               TRUE);
        e_source_authentication_set_method (
                E_SOURCE_AUTHENTICATION (source_extension),
                CAMEL_OAUTH_MECHANISM_NAME);
@@ -561,9 +558,6 @@ gnome_online_accounts_config_oauth2 (EGnomeOnlineAccounts *extension,
        extension_name = E_SOURCE_EXTENSION_AUTHENTICATION;
        source_extension = e_source_get_extension (source, extension_name);
 
-       e_source_authentication_set_is_external (
-               E_SOURCE_AUTHENTICATION (source_extension),
-               TRUE);
        e_source_authentication_set_method (
                E_SOURCE_AUTHENTICATION (source_extension),
                CAMEL_OAUTH2_MECHANISM_NAME);
@@ -589,6 +583,9 @@ gnome_online_accounts_config_collection (EGnomeOnlineAccounts *extension,
                source, "display-name",
                G_BINDING_SYNC_CREATE);
 
+       source_extension = e_source_get_extension (source, E_SOURCE_EXTENSION_AUTHENTICATION);
+       e_source_authentication_set_is_external (E_SOURCE_AUTHENTICATION (source_extension), TRUE);
+
        extension_name = E_SOURCE_EXTENSION_GOA;
        source_extension = e_source_get_extension (source, extension_name);