[libgee] Constructors of abstract classes should not be public



commit e1d352935bec5f356669603ef5803d5ba7c8cd2e
Author: Rico Tzschichholz <ricotz ubuntu com>
Date:   Thu Mar 14 15:05:21 2019 +0100

    Constructors of abstract classes should not be public

 gee/abstractmultimap.vala     | 2 +-
 gee/abstractmultiset.vala     | 2 +-
 gee/hashmap.vala              | 4 ++--
 tests/testbidirlist.vala      | 2 +-
 tests/testbidirsortedmap.vala | 2 +-
 tests/testbidirsortedset.vala | 2 +-
 tests/testcase.vala           | 2 +-
 tests/testcollection.vala     | 2 +-
 tests/testdeque.vala          | 2 +-
 tests/testlist.vala           | 2 +-
 tests/testmap.vala            | 2 +-
 tests/testmultimap.vala       | 2 +-
 tests/testmultiset.vala       | 2 +-
 tests/testqueue.vala          | 2 +-
 tests/testset.vala            | 2 +-
 tests/testsortedmap.vala      | 2 +-
 tests/testsortedset.vala      | 2 +-
 17 files changed, 18 insertions(+), 18 deletions(-)
---
diff --git a/gee/abstractmultimap.vala b/gee/abstractmultimap.vala
index af60470..b777f4e 100644
--- a/gee/abstractmultimap.vala
+++ b/gee/abstractmultimap.vala
@@ -39,7 +39,7 @@ public abstract class Gee.AbstractMultiMap<K,V> : Object, MultiMap<K,V> {
        protected Map<K, Collection<V>> _storage_map;
        private int _nitems = 0;
 
-       public AbstractMultiMap (Map<K, Collection<V>> storage_map) {
+       protected AbstractMultiMap (Map<K, Collection<V>> storage_map) {
                this._storage_map = storage_map;
        }
 
diff --git a/gee/abstractmultiset.vala b/gee/abstractmultiset.vala
index b237814..ecdc8ac 100644
--- a/gee/abstractmultiset.vala
+++ b/gee/abstractmultiset.vala
@@ -42,7 +42,7 @@ public abstract class Gee.AbstractMultiSet<G> : AbstractCollection<G>, MultiSet<
        /**
         * Constructs a new, empty abstract multi set.
         */
-       public AbstractMultiSet (Map<G, int> storage_map) {
+       protected AbstractMultiSet (Map<G, int> storage_map) {
                this._storage_map = storage_map;
        }
 
diff --git a/gee/hashmap.vala b/gee/hashmap.vala
index 83243a7..8d6b158 100644
--- a/gee/hashmap.vala
+++ b/gee/hashmap.vala
@@ -491,12 +491,12 @@ public class Gee.HashMap<K,V> : Gee.AbstractMap<K,V> {
        }
 
        private abstract class NodeIterator<K,V> : Object {
-               public NodeIterator (HashMap map) {
+               protected NodeIterator (HashMap map) {
                        _map = map;
                        _stamp = _map._stamp;
                }
 
-               public NodeIterator.from_iterator (NodeIterator<K,V> iter) {
+               protected NodeIterator.from_iterator (NodeIterator<K,V> iter) {
                        _map = iter._map;
                        _index = iter._index;
                        _node = iter._node;
diff --git a/tests/testbidirlist.vala b/tests/testbidirlist.vala
index 7e53f5b..8ad3cc9 100644
--- a/tests/testbidirlist.vala
+++ b/tests/testbidirlist.vala
@@ -25,7 +25,7 @@ using Gee;
 
 public abstract class BidirListTests : ListTests {
 
-       public BidirListTests (string name) {
+       protected BidirListTests (string name) {
                base (name);
                add_test ("[List] bi-directional list iterator", test_bidir_list_iterator);
        }
diff --git a/tests/testbidirsortedmap.vala b/tests/testbidirsortedmap.vala
index 385d715..7bbadf3 100644
--- a/tests/testbidirsortedmap.vala
+++ b/tests/testbidirsortedmap.vala
@@ -23,7 +23,7 @@ using GLib;
 using Gee;
 
 public abstract class BidirSortedMapTests : SortedMapTests {
-       public BidirSortedMapTests(string name) {
+       protected BidirSortedMapTests(string name) {
                base (name);
                add_test ("[SortedMap] bi-directional iterators can go backward",
                          test_bidir_iterator_can_go_backward);
diff --git a/tests/testbidirsortedset.vala b/tests/testbidirsortedset.vala
index df5da60..1c8bc8e 100644
--- a/tests/testbidirsortedset.vala
+++ b/tests/testbidirsortedset.vala
@@ -23,7 +23,7 @@ using GLib;
 using Gee;
 
 public abstract class BidirSortedSetTests : SortedSetTests {
-       public BidirSortedSetTests(string name) {
+       protected BidirSortedSetTests(string name) {
                base (name);
                add_test ("[SortedSet] bi-directional iterators can go backward",
                          test_bidir_iterator_can_go_backward);
diff --git a/tests/testcase.vala b/tests/testcase.vala
index 83a37ae..79a72a1 100644
--- a/tests/testcase.vala
+++ b/tests/testcase.vala
@@ -27,7 +27,7 @@ public abstract class Gee.TestCase : Object {
 
        public delegate void TestMethod ();
 
-       public TestCase (string name) {
+       protected TestCase (string name) {
                this.suite = new GLib.TestSuite (name);
        }
 
diff --git a/tests/testcollection.vala b/tests/testcollection.vala
index 819e130..c2ce182 100644
--- a/tests/testcollection.vala
+++ b/tests/testcollection.vala
@@ -29,7 +29,7 @@ using Gee;
 
 public abstract class CollectionTests : Gee.TestCase {
 
-       public CollectionTests (string name) {
+       protected CollectionTests (string name) {
                base (name);
                add_test ("[Collection] type correctness", test_type_correctness);
                add_test ("[Collection] iterator returns all elements once",
diff --git a/tests/testdeque.vala b/tests/testdeque.vala
index ff2d320..6dd4831 100644
--- a/tests/testdeque.vala
+++ b/tests/testdeque.vala
@@ -24,7 +24,7 @@ using Gee;
 
 public abstract class DequeTests : QueueTests {
 
-       public DequeTests (string name) {
+       protected DequeTests (string name) {
                base (name);
                add_test ("[Deque] queue use", test_queue_use);
                add_test ("[Deque] stack use", test_stack_use);
diff --git a/tests/testlist.vala b/tests/testlist.vala
index 1873dfc..a2aa923 100644
--- a/tests/testlist.vala
+++ b/tests/testlist.vala
@@ -28,7 +28,7 @@ using Gee;
 
 public abstract class ListTests : CollectionTests {
 
-       public ListTests (string name) {
+       protected ListTests (string name) {
                base (name);
                add_test ("[List] iterator is ordered", test_iterator_is_ordered);
                add_test ("[List] list iterator", test_list_iterator);
diff --git a/tests/testmap.vala b/tests/testmap.vala
index 468d477..36cc5f1 100644
--- a/tests/testmap.vala
+++ b/tests/testmap.vala
@@ -27,7 +27,7 @@ using Gee;
 
 public abstract class MapTests : Gee.TestCase {
 
-       public MapTests (string name) {
+       protected MapTests (string name) {
                base (name);
                add_test ("[Map] type correctness", test_type_correctness);
                add_test ("[Map] has_key, size and is_empty",
diff --git a/tests/testmultimap.vala b/tests/testmultimap.vala
index 0531be6..c8bd4da 100644
--- a/tests/testmultimap.vala
+++ b/tests/testmultimap.vala
@@ -28,7 +28,7 @@ using Gee;
 
 public abstract class MultiMapTests : Gee.TestCase {
 
-       public MultiMapTests (string name) {
+       protected MultiMapTests (string name) {
                base (name);
                add_test ("[MultiMap] type correctness", test_type_correctness);
                add_test ("[MultiMap] size", test_size);
diff --git a/tests/testmultiset.vala b/tests/testmultiset.vala
index 6812bdd..2cb965c 100644
--- a/tests/testmultiset.vala
+++ b/tests/testmultiset.vala
@@ -28,7 +28,7 @@ using Gee;
 
 public abstract class MultiSetTests : CollectionTests {
 
-       public MultiSetTests (string name) {
+       protected MultiSetTests (string name) {
                base (name);
                add_test ("[MultiSet] duplicates are retained",
                          test_duplicates_are_retained);
diff --git a/tests/testqueue.vala b/tests/testqueue.vala
index aaeb545..a0069b6 100644
--- a/tests/testqueue.vala
+++ b/tests/testqueue.vala
@@ -24,7 +24,7 @@ using Gee;
 
 public abstract class QueueTests : CollectionTests {
 
-       public QueueTests (string name) {
+       protected QueueTests (string name) {
                base (name);
                add_test ("[Queue] capacity bound", test_capacity_bound);
                add_test ("[Queue] one element operation", test_one_element_operation);
diff --git a/tests/testset.vala b/tests/testset.vala
index e2fc83f..eb07707 100644
--- a/tests/testset.vala
+++ b/tests/testset.vala
@@ -28,7 +28,7 @@ using Gee;
 
 public abstract class SetTests : CollectionTests {
 
-       public SetTests (string name) {
+       protected SetTests (string name) {
                base (name);
                add_test ("[Set] duplicates are ignored", test_duplicates_are_ignored);
        }
diff --git a/tests/testsortedmap.vala b/tests/testsortedmap.vala
index abfbfc8..4574a99 100644
--- a/tests/testsortedmap.vala
+++ b/tests/testsortedmap.vala
@@ -21,7 +21,7 @@
  */
 
 public abstract class Gee.SortedMapTests : MapTests {
-       public SortedMapTests (string name) {
+       protected SortedMapTests (string name) {
                base (name);
                add_test ("[SortedMap] key ordering", test_key_ordering);
                add_test ("[SortedMap] first", test_first);
diff --git a/tests/testsortedset.vala b/tests/testsortedset.vala
index 00c9bd2..029a516 100644
--- a/tests/testsortedset.vala
+++ b/tests/testsortedset.vala
@@ -24,7 +24,7 @@ using GLib;
 using Gee;
 
 public abstract class SortedSetTests : SetTests {
-       public SortedSetTests (string name, bool strict = true) {
+       protected SortedSetTests (string name, bool strict = true) {
                base (name);
                this.strict = strict;
                add_test ("[SortedSet] first", test_first);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]