[orca] Proceed with SayAll on page load if context is focusable but not focused



commit c48f8ca49e3dc7560609efc846a30f1729b5d8ad
Author: Joanmarie Diggs <jdiggs igalia com>
Date:   Thu Aug 1 11:11:25 2019 -0400

    Proceed with SayAll on page load if context is focusable but not focused
    
    If the author has not explicitly set focus on an item in the page, we
    should proceed with SayAll -- assuming the user has that preference
    enabled.

 src/orca/scripts/web/script.py | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)
---
diff --git a/src/orca/scripts/web/script.py b/src/orca/scripts/web/script.py
index 45654cdb0..a73b4b399 100644
--- a/src/orca/scripts/web/script.py
+++ b/src/orca/scripts/web/script.py
@@ -1359,13 +1359,13 @@ class Script(default.Script):
 
         state = obj.getState()
         if self.utilities.isLink(obj) and state.contains(pyatspi.STATE_FOCUSED):
-            msg = "WEB: Setting locus of focus to focused link %s" % obj
+            msg = "WEB: Setting locus of focus to focused link %s. No SayAll." % obj
             debug.println(debug.LEVEL_INFO, msg, True)
             orca.setLocusOfFocus(event, obj)
             return True
 
         if offset > 0:
-            msg = "WEB: Setting locus of focus to context obj %s" % obj
+            msg = "WEB: Setting locus of focus to context obj %s. No SayAll" % obj
             debug.println(debug.LEVEL_INFO, msg, True)
             orca.setLocusOfFocus(event, obj)
             return True
@@ -1383,11 +1383,7 @@ class Script(default.Script):
             orca.setLocusOfFocus(event, obj, False)
 
         self.updateBraille(obj)
-        if state.contains(pyatspi.STATE_FOCUSABLE) and not self.utilities.isDocument(obj):
-            msg = "WEB: Not doing SayAll due to focusable context obj %s" % obj
-            debug.println(debug.LEVEL_INFO, msg, True)
-            speech.speak(self.speechGenerator.generateSpeech(obj))
-        elif self.utilities.documentFragment(event.source):
+        if self.utilities.documentFragment(event.source):
             msg = "WEB: Not doing SayAll due to page fragment"
             debug.println(debug.LEVEL_INFO, msg, True)
         elif not _settingsManager.getSetting('sayAllOnLoad'):


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]