[pitivi] Remove obsolete TODOs and FIXMEs



commit e529a3e67dd7245030cfd52054e236cc6af5996c
Author: Alexandru Băluț <alexandru balut gmail com>
Date:   Sun Nov 18 23:49:43 2018 +0100

    Remove obsolete TODOs and FIXMEs
    
    Fixes #2209

 pitivi/editorperspective.py   |  4 +---
 pitivi/project.py             |  1 -
 pitivi/render.py              |  1 -
 pitivi/timeline/elements.py   | 10 +++-------
 pitivi/timeline/previewers.py |  2 +-
 pitivi/transitions.py         |  4 ----
 tests/test_render.py          |  1 -
 7 files changed, 5 insertions(+), 18 deletions(-)
---
diff --git a/pitivi/editorperspective.py b/pitivi/editorperspective.py
index af79e94f..a3a3a38f 100644
--- a/pitivi/editorperspective.py
+++ b/pitivi/editorperspective.py
@@ -479,9 +479,7 @@ class EditorPerspective(Perspective, Loggable):
         dialog.destroy()
         self.error("failed to save project")
 
-    def _projectManagerProjectSavedCb(self, unused_project_manager, project, uri):
-        # FIXME GES: Reimplement Undo/Redo
-        # self.app.action_log.checkpoint()
+    def _projectManagerProjectSavedCb(self, unused_project_manager, unused_project, unused_uri):
         self.updateTitle()
         self.save_action.set_enabled(False)
 
diff --git a/pitivi/project.py b/pitivi/project.py
index a760e783..5ed923f1 100644
--- a/pitivi/project.py
+++ b/pitivi/project.py
@@ -1893,7 +1893,6 @@ class Project(Loggable, GES.Project):
 
     def _emit_change(self, key):
         self.emit("rendering-settings-changed", key)
-        # TODO: Remove this when it's possible to undo/redo these changes.
         self.setModificationState(True)
 
     def _getElementFactoryName(self, elements, profile):
diff --git a/pitivi/render.py b/pitivi/render.py
index 24f5227b..afd5415b 100644
--- a/pitivi/render.py
+++ b/pitivi/render.py
@@ -869,7 +869,6 @@ class RenderDialog(Loggable):
     def startAction(self):
         """Starts the render process."""
         self._pipeline.set_state(Gst.State.NULL)
-        # FIXME: https://github.com/pitivi/gst-editing-services/issues/23
         self._pipeline.set_mode(GES.PipelineFlags.RENDER)
         encodebin = self._pipeline.get_by_name("internal-encodebin")
         self._gstSigId[encodebin] = encodebin.connect(
diff --git a/pitivi/timeline/elements.py b/pitivi/timeline/elements.py
index 6e1b4890..e207cd86 100644
--- a/pitivi/timeline/elements.py
+++ b/pitivi/timeline/elements.py
@@ -55,8 +55,8 @@ KEYFRAME_LINE_HEIGHT = 2
 KEYFRAME_LINE_ALPHA = 0.5
 KEYFRAME_LINE_COLOR = "#EDD400"  # "Tango" medium yellow
 KEYFRAME_NODE_COLOR = "#F57900"  # "Tango" medium orange
-SELECTED_KEYFRAME_NODE_COLOR = "#204A87" # "Tango" dark sky blue
-HOVERED_KEYFRAME_NODE_COLOR = "#3465A4" # "Tango" medium sky blue
+SELECTED_KEYFRAME_NODE_COLOR = "#204A87"  # "Tango" dark sky blue
+HOVERED_KEYFRAME_NODE_COLOR = "#3465A4"  # "Tango" medium sky blue
 
 CURSORS = {
     GES.Edge.EDGE_START: Gdk.Cursor.new(Gdk.CursorType.LEFT_SIDE),
@@ -116,11 +116,7 @@ class KeyframeCurve(FigureCanvas, Loggable):
         self._ax = figure.add_axes([0, 0, 1, 1], facecolor='None')
         # Clear the Axes object.
         self._ax.cla()
-
-        # FIXME: drawing a grid and ticks would be nice, but
-        # matplotlib is too slow for now.
         self._ax.grid(False)
-
         self._ax.tick_params(axis='both',
                              which='both',
                              bottom=False,
@@ -462,7 +458,7 @@ class MultipleKeyframeCurve(KeyframeCurve):
         self.__selected_keyframe = self._ax.scatter([0], [0.5], marker='D', s=sizes,
                                                     c=SELECTED_KEYFRAME_NODE_COLOR, zorder=3)
         self.__hovered_keyframe = self._ax.scatter([0], [0.5], marker='D', s=sizes,
-                                                    c=HOVERED_KEYFRAME_NODE_COLOR, zorder=3)
+                                                   c=HOVERED_KEYFRAME_NODE_COLOR, zorder=3)
         self.__update_selected_keyframe()
         self.__hovered_keyframe.set_visible(False)
 
diff --git a/pitivi/timeline/previewers.py b/pitivi/timeline/previewers.py
index f9541d27..66f4ce32 100644
--- a/pitivi/timeline/previewers.py
+++ b/pitivi/timeline/previewers.py
@@ -1030,7 +1030,7 @@ class AudioPreviewer(Previewer, Zoomable, Loggable):
             self.stop_generation()
 
         elif message.type == Gst.MessageType.ERROR:
-            # Something went wrong TODO : recover
+            # Something went wrong.
             self.stop_generation()
             self._num_failures += 1
             if self._num_failures < 2:
diff --git a/pitivi/transitions.py b/pitivi/transitions.py
index 0ce76802..8062aad8 100644
--- a/pitivi/transitions.py
+++ b/pitivi/transitions.py
@@ -115,10 +115,6 @@ class TransitionsListWidget(Gtk.Box, Loggable):
 
         self.iconview_scrollwin = Gtk.ScrolledWindow()
         self.iconview_scrollwin.set_shadow_type(Gtk.ShadowType.ETCHED_IN)
-        # FIXME: the "never" horizontal scroll policy in GTK2 messes up iconview
-        # Re-enable this when we switch to GTK3
-        # See also http://python.6.n6.nabble.com/Cannot-shrink-width-of-scrolled-textview-tp1945060.html
-        # self.iconview_scrollwin.set_policy(Gtk.PolicyType.NEVER, Gtk.PolicyType.AUTOMATIC)
 
         self.iconview = Gtk.IconView(model=self.storemodel)
         self.iconview.set_pixbuf_column(COL_ICON)
diff --git a/tests/test_render.py b/tests/test_render.py
index c495be89..1c83ec08 100644
--- a/tests/test_render.py
+++ b/tests/test_render.py
@@ -302,7 +302,6 @@ class TestRender(BaseTestMediaLibrary):
             self.assertEqual(message.type, Gst.MessageType.EOS,
                              struct.to_string() if struct else message)
             asset = GES.UriClipAsset.request_sync(result_file)
-            # FIXME Check more things?
             self.assertIsNotNone(asset)
 
             if message:


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]