[balsa/wip/gtk4: 124/351] mailbox-pop3: Fix progress dialogue on error

[Peter Bloomfield <peterb src gnome org>]

commit cab81e4f25439f0b2c105f342932bd676b3c886e
Author: Albrecht Dreß <albrecht dress arcor de>
Date:   Thu Jan 11 13:37:55 2018 -0500

    mailbox-pop3: Fix progress dialogue on error
    
    Signed-off-by: Peter Bloomfield <PeterBloomfield bellsouth net>

 ChangeLog               |   14 ++++++++++++++
 libbalsa/mailbox_pop3.c |    5 +++--
 2 files changed, 17 insertions(+), 2 deletions(-)
---
diff --git a/ChangeLog b/ChangeLog
index d57243d..a895aa2 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,17 @@
+2018-01-11  Albrecht Dreß <albrecht dress arcor de>
+
+       Fix progress dialogue on error
+
+       * libbalsa/mailbox_pop3.c (libbalsa_mailbox_pop3_check): send
+       the “finalise” notification to the dialogue even if opening
+       the connection fails.
+
+2018-01-06  Albrecht Dreß <albrecht dress arcor de>
+
+       Fix the meson build
+
+       * src/meson.build: threads.h is no more.
+
 2018-01-05  Albrecht Dreß <albrecht dress arcor de>
 
        Enable multi-threaded POP3 retrieval
diff --git a/libbalsa/mailbox_pop3.c b/libbalsa/mailbox_pop3.c
index ae97e46..59871b5 100644
--- a/libbalsa/mailbox_pop3.c
+++ b/libbalsa/mailbox_pop3.c
@@ -623,7 +623,7 @@ libbalsa_mailbox_pop3_check(LibBalsaMailbox * mailbox)
 
        server = LIBBALSA_MAILBOX_REMOTE_SERVER(mbox);
 
-       /* open the mailbox connection and get the messages list */
+       /* open the mailbox connection and get the messages list (note: initiates the progress dialogue) */
        pop = libbalsa_mailbox_pop3_startup(server, mbox, mailbox->name, &msg_list);
 
        /* proceed on success only */
@@ -690,8 +690,9 @@ libbalsa_mailbox_pop3_check(LibBalsaMailbox * mailbox)
 
                /* done - clean up */
                g_object_unref(G_OBJECT(pop));
-               libbalsa_mailbox_progress_notify(mailbox, LIBBALSA_NTFY_FINISHED, 1.0, _("Finished"));
        }
+
+       libbalsa_mailbox_progress_notify(mailbox, LIBBALSA_NTFY_FINISHED, 1.0, _("Finished"));
 }