[gtk-doc] fixxref: Don't crash if a .devhelp2.gz file is present



commit d6a75bdf26f61889e5d01e8af499b59b2de011b0
Author: Simon McVittie <smcv debian org>
Date:   Tue Oct 3 14:20:26 2017 +0100

    fixxref: Don't crash if a .devhelp2.gz file is present
    
    devhelp itself supports gzip-compressed indices (since 2003), but gtk-doc
    does not. The Debian packaging toolchain was changed in 2015 to avoid
    compressing those files (Debian #789153[1], Launchpad #1466210[2]),
    but a few undermaintained packages (gespeaker, libsocialweb, ogmrip,
    telepathy-glib) have not been rebuilt since then and so still install
    devhelp2.gz indices.
    
    The %d printf-style format specifier in Python expects an integer,
    so emitting a warning about those packages would cause gtk-doc
    to crash. Use %s instead.
    
    [1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=789153
    [2] https://bugs.launchpad.net/ubuntu/+source/gtk-doc/+bug/1466210
    
    Signed-off-by: Simon McVittie <smcv debian org>
    
    https://bugzilla.gnome.org/show_bug.cgi?id=788473

 gtkdoc/fixxref.py |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/gtkdoc/fixxref.py b/gtkdoc/fixxref.py
index a7029cb..052e1ed 100755
--- a/gtkdoc/fixxref.py
+++ b/gtkdoc/fixxref.py
@@ -144,7 +144,7 @@ gunzip %s
         elif entry.endswith('.devhelp2.gz') and not os.path.exists(full_entry[:-3]):
             # debian/ubuntu started to compress this as *devhelp2.gz :/
             print('''Please fix https://bugs.launchpad.net/ubuntu/+source/gtk-doc/+bug/1466210 . For now run:
-gunzip %d
+gunzip %s
 ''' % full_entry)
         # we could consider supporting: gzip module
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]