[gimp] Bug 790261 - autogen.sh non-portable use of echo -n.



commit d6c72d0f7146cb7262581c48f7b4c44786fcb3aa
Author: Jehan <jehan girinstud io>
Date:   Tue Nov 14 02:59:07 2017 +0100

    Bug 790261 - autogen.sh non-portable use of echo -n.
    
    The reporter notes in particular that the -n option does not work
    appropriately on recent versions of macOS.
    From what I know, echo without any option is the most portable. But when
    options are needed, there are too many variants of the command out
    there, and printf becomes more reliable and consistent across platforms.
    It is more recent than echo and therefore non-portable for very very old
    platforms, but let's assume/hope that it old-enough for not being a
    problem anymore.

 autogen.sh |   12 ++++++------
 1 files changed, 6 insertions(+), 6 deletions(-)
---
diff --git a/autogen.sh b/autogen.sh
index 33b1940..089ec2d 100755
--- a/autogen.sh
+++ b/autogen.sh
@@ -89,7 +89,7 @@ case $OS in
        ;;
 esac
 
-echo -n "checking for libtool >= $LIBTOOL_REQUIRED_VERSION ... "
+printf "checking for libtool >= $LIBTOOL_REQUIRED_VERSION ... "
 if ($LIBTOOLIZE --version) < /dev/null > /dev/null 2>&1; then
    LIBTOOLIZE=$LIBTOOLIZE
 elif (glibtoolize --version) < /dev/null > /dev/null 2>&1; then
@@ -122,7 +122,7 @@ done
 if test x$enable_gtk_doc = xno; then
   echo "skipping test for gtkdocize"
 else
-  echo -n "checking for gtkdocize ... "
+  printf "checking for gtkdocize ... "
   if (gtkdocize --version) < /dev/null > /dev/null 2>&1; then
       echo "yes"
   else
@@ -138,7 +138,7 @@ else
   fi
 fi
 
-echo -n "checking for autoconf >= $AUTOCONF_REQUIRED_VERSION ... "
+printf "checking for autoconf >= $AUTOCONF_REQUIRED_VERSION ... "
 if ($AUTOCONF --version) < /dev/null > /dev/null 2>&1; then
     VER=`$AUTOCONF --version | head -n 1 \
          | grep -iw autoconf | sed "s/.* \([0-9.]*\)[-a-z0-9]*$/\1/"`
@@ -153,7 +153,7 @@ else
 fi
 
 
-echo -n "checking for automake >= $AUTOMAKE_REQUIRED_VERSION ... "
+printf "checking for automake >= $AUTOMAKE_REQUIRED_VERSION ... "
 if ($AUTOMAKE --version) < /dev/null > /dev/null 2>&1; then
    AUTOMAKE=$AUTOMAKE
    ACLOCAL=$ACLOCAL
@@ -185,7 +185,7 @@ if test x$AUTOMAKE != x; then
 fi
 
 
-echo -n "checking for intltool >= $INTLTOOL_REQUIRED_VERSION ... "
+printf "checking for intltool >= $INTLTOOL_REQUIRED_VERSION ... "
 if (intltoolize --version) < /dev/null > /dev/null 2>&1; then
     VER=`intltoolize --version \
          | grep intltoolize | sed "s/.* \([0-9.]*\)/\1/"`
@@ -200,7 +200,7 @@ else
 fi
 
 
-echo -n "checking for xsltproc ... "
+printf "checking for xsltproc ... "
 if (xsltproc --version) < /dev/null > /dev/null 2>&1; then
     echo "yes"
 else


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]