[extensions-web] extension-info: do not assume that pk is mandatory



commit 5b11492ee9b1feba297fd52b66495166f7a6b140
Author: Yuri Konotopov <ykonotopov gnome org>
Date:   Mon Feb 6 13:14:29 2017 +0400

    extension-info: do not assume that pk is mandatory

 sweettooth/extensions/views.py |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)
---
diff --git a/sweettooth/extensions/views.py b/sweettooth/extensions/views.py
index adbf7fc..da37e0f 100644
--- a/sweettooth/extensions/views.py
+++ b/sweettooth/extensions/views.py
@@ -337,15 +337,15 @@ def ajax_details(extension, version=None):
 @ajax_view
 def ajax_details_view(request):
     uuid = request.GET.get('uuid', None)
-    try:
-        pk = int(request.GET.get('pk', None))
-    except (TypeError, ValueError):
-        raise Http404()
+    pk = request.GET.get('pk', None)
 
     if uuid is not None:
         extension = get_object_or_404(models.Extension.objects.visible(), uuid=uuid)
     elif pk is not None:
-        extension = get_object_or_404(models.Extension.objects.visible(), pk=pk)
+        try:
+            extension = get_object_or_404(models.Extension.objects.visible(), pk=pk)
+        except (TypeError, ValueError):
+            raise Http404()
     else:
         raise Http404()
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]