[gnome-continuous-yocto/gnomeostree-3.28-rocko: 6546/8267] bitbake: toaster: large package set breaks sqlite query



commit eea5cb317137d71ad0cab954d2c9ad2069580b6f
Author: David Reyna <David Reyna windriver com>
Date:   Tue Jun 27 13:44:31 2017 -0700

    bitbake: toaster: large package set breaks sqlite query
    
    If you build a project with a large package set, you will get a crash
    in "views.py" when the dashboard attempts to fetch the package set to
    calculate the package count and size. This is a sqlite limitation, and
    it fails with as few as 1220 packages.
    
    [YOCTO #11717]
    
    (Bitbake rev: 02cb2b7f7ff594de75a404396f39a2428750c798)
    
    Signed-off-by: David Reyna <David Reyna windriver com>
    Signed-off-by: Richard Purdie <richard purdie linuxfoundation org>

 bitbake/lib/toaster/toastergui/views.py |   13 +++++++++----
 1 files changed, 9 insertions(+), 4 deletions(-)
---
diff --git a/bitbake/lib/toaster/toastergui/views.py b/bitbake/lib/toaster/toastergui/views.py
index 75c5911..5720b9d 100755
--- a/bitbake/lib/toaster/toastergui/views.py
+++ b/bitbake/lib/toaster/toastergui/views.py
@@ -457,10 +457,15 @@ def builddashboard( request, build_id ):
         npkg = 0
         pkgsz = 0
         package = None
-        for package in Package.objects.filter(id__in = [x.package_id for x in 
t.target_installed_package_set.all()]):
-            pkgsz = pkgsz + package.size
-            if package.installed_name:
-                npkg = npkg + 1
+        # Chunk the query to avoid "too many SQL variables" error
+        package_set = t.target_installed_package_set.all()
+        package_set_len = len(package_set)
+        for ps_start in range(0,package_set_len,500):
+            ps_stop = min(ps_start+500,package_set_len)
+            for package in Package.objects.filter(id__in = [x.package_id for x in 
package_set[ps_start:ps_stop]]):
+                pkgsz = pkgsz + package.size
+                if package.installed_name:
+                    npkg = npkg + 1
         elem['npkg'] = npkg
         elem['pkgsz'] = pkgsz
         ti = Target_Image_File.objects.filter(target_id = t.id)


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]