[grilo-plugins] tests: metrolyrics with encoded url



commit 70697337a25d3c6d6b68f52d89b998884e2e10a1
Author: Victor Toso <me victortoso com>
Date:   Sat Apr 9 15:23:53 2016 +0200

    tests: metrolyrics with encoded url
    
    Check that we don't create invalid requests for the metrolyrics server
    
    https://bugzilla.gnome.org/show_bug.cgi?id=764814

 tests/lua-factory/sources/test_lua_metrolyrics.c |   11 +++++++++--
 1 files changed, 9 insertions(+), 2 deletions(-)
---
diff --git a/tests/lua-factory/sources/test_lua_metrolyrics.c 
b/tests/lua-factory/sources/test_lua_metrolyrics.c
index b6ee330..82b6cf8 100644
--- a/tests/lua-factory/sources/test_lua_metrolyrics.c
+++ b/tests/lua-factory/sources/test_lua_metrolyrics.c
@@ -81,6 +81,7 @@ test_resolve_metrolyrics (void)
    { "back it up", "caro emerald", LYRICS_BACK_IT_UP },
    { "bohemian rhapsody", "queen", LYRICS_BOHEMIAN_RHAPSODY },
    { "nobodys perfect", "jessie j", LYRICS_NOBODYS_PERFECT },
+   { "100% pure love", "crystal waters", NULL },
   };
 
   source = test_lua_factory_get_source (METROLYRICS_ID, METROLYRICS_OPS);
@@ -91,13 +92,19 @@ test_resolve_metrolyrics (void)
     gsize size;
     GError *error = NULL;
 
+    lyrics = get_lyrics (source, audios[i].artist, audios[i].title);
+    if (audios[i].lyrics_file == NULL) {
+        /* We are not interested in comparing this lyrics */
+        g_clear_pointer (&lyrics, g_free);
+        continue;
+    }
+    g_assert_nonnull (lyrics);
+
     file = g_file_new_for_uri (audios[i].lyrics_file);
     g_file_load_contents (file, NULL, &data, &size, NULL, &error);
     g_assert_no_error (error);
     g_clear_pointer (&file, g_object_unref);
 
-    lyrics = get_lyrics (source, audios[i].artist, audios[i].title);
-    g_assert_nonnull (lyrics);
     if (g_ascii_strncasecmp (lyrics, data, size - 1) != 0) {
       g_warning ("Lyrics of '%s' from '%s' changed. Check if metrolyrics.com changed",
                   audios[i].title, audios[i].artist);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]