[easytag] Remove unnecessary NULL check in CDDB dialog



commit 2703196a5c7446c0873aa71bdd3d26428ed53296
Author: David King <amigadave amigadave com>
Date:   Thu Jan 22 16:32:20 2015 +0000

    Remove unnecessary NULL check in CDDB dialog
    
    Found with Coverity (CID 1265641).

 src/cddb_dialog.c |    9 +++------
 1 files changed, 3 insertions(+), 6 deletions(-)
---
diff --git a/src/cddb_dialog.c b/src/cddb_dialog.c
index 1d17736..0b8a041 100644
--- a/src/cddb_dialog.c
+++ b/src/cddb_dialog.c
@@ -1219,12 +1219,9 @@ Cddb_Get_Album_Tracks_List (EtCDDBDialog *self, GtkTreeSelection* selection)
         file = NULL;
     }
 
-    if (cddb_server_name)
-    {
-        /* Remote access. */
-        /* Close connection */
-        Cddb_Close_Connection (self, socket_id);
-    }
+    /* Remote access. */
+    /* Close connection */
+    Cddb_Close_Connection (self, socket_id);
 
     /* Set color of the selected row (without reloading the whole list) */
     Cddb_Album_List_Set_Row_Appearance (self, &row);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]