[gnome-online-accounts/gnome-3-14] identity: plug leak in identity service



commit 9e4053d25e81a3e31eb2aa3022594c010b79cbbb
Author: Ray Strode <rstrode redhat com>
Date:   Wed Oct 29 16:12:31 2014 -0400

    identity: plug leak in identity service
    
    When the identity service first starts up, it gets a list
    of preexisting kerberos principals and then exports them
    over the bus.
    
    The object path used for the exported objects is getting leaked.
    This commit fixes that.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=739590

 src/goaidentity/goaidentityservice.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)
---
diff --git a/src/goaidentity/goaidentityservice.c b/src/goaidentity/goaidentityservice.c
index d2ce877..06fb946 100644
--- a/src/goaidentity/goaidentityservice.c
+++ b/src/goaidentity/goaidentityservice.c
@@ -1601,8 +1601,9 @@ on_identities_listed (GoaIdentityManager *manager,
       GoaIdentity *identity = node->data;
       const char  *principal;
       GoaObject   *object;
+      char        *object_path;
 
-      export_identity (self, identity);
+      object_path = export_identity (self, identity);
 
       principal = goa_identity_get_identifier (identity);
 
@@ -1612,6 +1613,8 @@ on_identities_listed (GoaIdentityManager *manager,
         add_temporary_account (self, identity);
       else
         g_object_unref (object);
+
+      g_free (object_path);
     }
 
  out:


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]