[gnome-shell] shell: Make KeyringPrompt.cancel() callable from signal handlers



commit a89fd17b8e6395b93463b98e35b00c7ce035a57b
Author: Florian Müllner <fmuellner gnome org>
Date:   Wed Sep 18 19:21:50 2013 +0200

    shell: Make KeyringPrompt.cancel() callable from signal handlers
    
    gcr/gnome-keyring don't handle the case where prompt_password_async()/
    prompt_confirm_async() return their result from within the function
    very well (or rather: break badly). Calling gcr_prompt_close() instead
    is safe, but to avoid these kind of errors in the future, modify
    shell_keyring_prompt_cancel() to work as expected in this case.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=708187

 src/shell-keyring-prompt.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/src/shell-keyring-prompt.c b/src/shell-keyring-prompt.c
index bafcb90..2e9bc67 100644
--- a/src/shell-keyring-prompt.c
+++ b/src/shell-keyring-prompt.c
@@ -771,6 +771,6 @@ shell_keyring_prompt_cancel (ShellKeyringPrompt *self)
   self->async_result = NULL;
   self->mode = PROMPTING_NONE;
 
-  g_simple_async_result_complete (res);
+  g_simple_async_result_complete_in_idle (res);
   g_object_unref (res);
 }


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]