[evince] libview: Avoid unnecessary region copies when selecting text



commit 7a7ebb8f2a56b4f8ec604c07886948c6bcec3b16
Author: Carlos Garcia Campos <carlosgc gnome org>
Date:   Thu Jun 27 15:03:35 2013 +0200

    libview: Avoid unnecessary region copies when selecting text
    
    Now that we always build a new damage region, we don't need to copy the
    selection covered region.

 libview/ev-view.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)
---
diff --git a/libview/ev-view.c b/libview/ev-view.c
index 234775b..15950b4 100644
--- a/libview/ev-view.c
+++ b/libview/ev-view.c
@@ -7292,17 +7292,17 @@ merge_selection_region (EvView *view,
                                        cairo_region_union (region, new_sel->covered_region);
                                }
                        } else if (old_sel->covered_region) {
-                               region = cairo_region_copy (old_sel->covered_region);
+                               region = cairo_region_reference (old_sel->covered_region);
                        } else if (new_sel->covered_region) {
-                               region = cairo_region_copy (new_sel->covered_region);
+                               region = cairo_region_reference (new_sel->covered_region);
                        }
                } else if (old_sel && !new_sel) {
                        if (old_sel->covered_region && !cairo_region_is_empty (old_sel->covered_region)) {
-                               region = cairo_region_copy (old_sel->covered_region);
+                               region = cairo_region_reference (old_sel->covered_region);
                        }
                } else if (!old_sel && new_sel) {
                        if (new_sel->covered_region && !cairo_region_is_empty (new_sel->covered_region)) {
-                               region = cairo_region_copy (new_sel->covered_region);
+                               region = cairo_region_reference (new_sel->covered_region);
                        }
                } else {
                        g_assert_not_reached ();


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]