[glib] GDBusMethodInvocation: add missing 'goto out'



commit edf16aace4033967dd2bcf9e05beff1c62190451
Author: Ryan Lortie <desrt desrt ca>
Date:   Sat Jun 22 13:41:12 2013 -0400

    GDBusMethodInvocation: add missing 'goto out'
    
    We do a bunch of new validity checks for return values in response to
    calls on the D-Bus property API but we miss the 'goto out' in one case.
    Add it.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=698375

 gio/gdbusmethodinvocation.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
---
diff --git a/gio/gdbusmethodinvocation.c b/gio/gdbusmethodinvocation.c
index bd40aaf..c6cab91 100644
--- a/gio/gdbusmethodinvocation.c
+++ b/gio/gdbusmethodinvocation.c
@@ -444,6 +444,8 @@ g_dbus_method_invocation_return_value_internal (GDBusMethodInvocation *invocatio
               g_warning ("Value returned from property 'Get' call for '%s' should be '%s' but is '%s'",
                          invocation->property_info->name, invocation->property_info->signature,
                          g_variant_get_type_string (nested));
+              g_variant_unref (nested);
+              goto out;
             }
           g_variant_unref (nested);
         }


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]