[gnumeric] GUI, ODS: Plug leaks.



commit 44832d9bfe0498d4f2bceac289961b4f258bdeb4
Author: Morten Welinder <terra gnome org>
Date:   Fri Jun 21 12:44:06 2013 -0400

    GUI, ODS: Plug leaks.

 ChangeLog                            |    6 ++++++
 NEWS                                 |    1 +
 plugins/openoffice/ChangeLog         |    4 ++++
 plugins/openoffice/openoffice-read.c |    1 +
 src/item-bar.c                       |    1 +
 src/item-grid.c                      |    3 ++-
 6 files changed, 15 insertions(+), 1 deletions(-)
---
diff --git a/ChangeLog b/ChangeLog
index dd3bdb8..caf2085 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2013-06-21  Morten Welinder  <terra gnome org>
+
+       * src/item-grid.c (item_grid_draw_region): Plug leak.
+
+       * src/item-bar.c (ib_reload_style): Plug leak.
+
 2013-06-20  Andreas J. Guelzow <aguelzow pyrshep ca>
 
        * src/wbc-gtk.c (show_gui): protect against excessively large
diff --git a/NEWS b/NEWS
index 513ddf0..680e968 100644
--- a/NEWS
+++ b/NEWS
@@ -69,6 +69,7 @@ Morten:
        * Fix crashes on corrupted files.  [#702101] [#702182] [#702218]
          [#702267] [#702277] [#702379] [#702658]
        * Improve xls import of new stat function names.
+       * Plug leaks.
 
 --------------------------------------------------------------------------
 Gnumeric 1.12.2
diff --git a/plugins/openoffice/ChangeLog b/plugins/openoffice/ChangeLog
index 0eaee9f..70dda4d 100644
--- a/plugins/openoffice/ChangeLog
+++ b/plugins/openoffice/ChangeLog
@@ -1,3 +1,7 @@
+2013-06-21  Morten Welinder  <terra gnome org>
+
+       * openoffice-read.c (odf_validation_free): Plug leak.
+
 2013-06-17  Andreas J. Guelzow <aguelzow pyrshep ca>
 
        * openoffice-read.c (oo_legend): watch for missing chart style
diff --git a/plugins/openoffice/openoffice-read.c b/plugins/openoffice/openoffice-read.c
index e89b2f5..6bbe1ce 100644
--- a/plugins/openoffice/openoffice-read.c
+++ b/plugins/openoffice/openoffice-read.c
@@ -2662,6 +2662,7 @@ odf_validation_free (odf_validation_t *val)
        g_free (val->title);
        if (val->message)
                g_string_free (val->message, TRUE);
+       g_free (val);
 }
 
 static odf_validation_t *
diff --git a/src/item-bar.c b/src/item-bar.c
index 64570c8..c891c64 100644
--- a/src/item-bar.c
+++ b/src/item-bar.c
@@ -144,6 +144,7 @@ ib_reload_style (GnmItemBar *ib)
                ib->selection_fonts[ui] =
                        pango_context_load_font (pcontext, desc);
                pango_layout_set_font_description (layout, desc);
+               pango_font_description_free (desc);
                pango_layout_get_extents (layout, &ink_rect, NULL);
                ib->selection_font_ascents[ui] =
                        PANGO_PIXELS (ink_rect.height + ink_rect.y);
diff --git a/src/item-grid.c b/src/item-grid.c
index 80b4ab1..5254c81 100644
--- a/src/item-grid.c
+++ b/src/item-grid.c
@@ -839,7 +839,8 @@ plain_draw : /* a quick hack to deal with 142267 */
                        ig_cairo_draw_bound (ig, cr, 1, start_y, 1, y);
        }
 
-       gtk_widget_destroy (entry);
+       g_object_ref_sink (entry);
+       g_object_unref (entry);
 
        g_slist_free (merged_used);        /* merges with bottom in view */
        g_slist_free (merged_active_seen); /* merges with bottom the view */


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]