[easytag/wip/clang-analyzer: 1/14] Add missing g_return_if_fail() calls



commit 40d53066c2c0b0829d04719bc2fb98a11aa0a2bd
Author: David King <amigadave amigadave com>
Date:   Sat Aug 10 22:51:30 2013 +0100

    Add missing g_return_if_fail() calls
    
    Found with the Clang static analyzer.

 src/browser.c |    4 ++--
 src/misc.c    |    2 ++
 src/setting.c |    2 ++
 3 files changed, 6 insertions(+), 2 deletions(-)
---
diff --git a/src/browser.c b/src/browser.c
index 26181af..b4d0749 100644
--- a/src/browser.c
+++ b/src/browser.c
@@ -3700,8 +3700,7 @@ Rename_Directory (void)
     gint   fd_tmp;
 
 
-    if (!RenameDirectoryWindow)
-        return;
+    g_return_if_fail (RenameDirectoryWindow != NULL);
 
     directory_parent    = g_object_get_data(G_OBJECT(RenameDirectoryWindow),"Parent_Directory");
     directory_last_name = g_object_get_data(G_OBJECT(RenameDirectoryWindow),"Current_Directory");
@@ -4235,6 +4234,7 @@ Run_Program (const gchar *program_name, GList *args_list)
     GList *l;
     gchar *program_path;
 
+    g_return_val_if_fail (program_name != NULL && args_list != NULL, FALSE);
 
     /* Check if a name for the program have been supplied */
     if (!program_name || strlen(program_name)<1)
diff --git a/src/misc.c b/src/misc.c
index 41e473f..f477204 100644
--- a/src/misc.c
+++ b/src/misc.c
@@ -762,6 +762,8 @@ Run_Audio_Player_Using_File_List (GList *etfilelist)
     gint    argv_user_number;
 #endif /* !G_OS_WIN32 */
 
+    g_return_if_fail (etfilelist != NULL);
+
     // Exit if no program selected...
     if (!AUDIO_FILE_PLAYER || strlen(g_strstrip(AUDIO_FILE_PLAYER))<1)
     {
diff --git a/src/setting.c b/src/setting.c
index 49520ce..d55acfa 100644
--- a/src/setting.c
+++ b/src/setting.c
@@ -1014,6 +1014,8 @@ Set_Config (gchar *line)
     gint ConfigVarListLen;
     gint i;
 
+    g_return_if_fail (line != NULL);
+
     if (*line=='\n' || *line=='#') return;
 
     /* Cut string */


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]