[gnome-ostree] build: Fixes for needs-rebuild computation
- From: Colin Walters <walters src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-ostree] build: Fixes for needs-rebuild computation
- Date: Wed, 19 Dec 2012 13:58:46 +0000 (UTC)
commit ba6db6b1c02afb7a03f05ee37e9c1c6f288cf7ab
Author: Colin Walters <walters verbum org>
Date: Wed Dec 19 08:56:27 2012 -0500
build: Fixes for needs-rebuild computation
* Add setuid key
* Correctly handle keys not being present at all, as well as being
removed.
src/ostbuild/js/build.js | 11 ++++++-----
1 files changed, 6 insertions(+), 5 deletions(-)
---
diff --git a/src/ostbuild/js/build.js b/src/ostbuild/js/build.js
index 293b883..80f62ad 100644
--- a/src/ostbuild/js/build.js
+++ b/src/ostbuild/js/build.js
@@ -224,13 +224,14 @@ const Build = new Lang.Class({
},
_needsRebuild: function(previousMetadata, newMetadata) {
- let buildKeys = ['config-opts', 'src', 'revision'];
+ let buildKeys = ['config-opts', 'src', 'revision', 'setuid'];
for (let i = 0; i < buildKeys.length; i++) {
let k = buildKeys[i];
- if (!newMetadata[k]) {
- return 'key ' + k + ' removed from new_metadata';
- }
- if (previousMetadata[k]) {
+ if (previousMetadata[k] && !newMetadata[k]) {
+ return 'key ' + k + ' removed';
+ } else if (!previousMetadata[k] && newMetadata[k]) {
+ return 'key ' + k + ' added';
+ } else if (previousMetadata[k] && newMetadata[k]) {
let oldval = previousMetadata[k];
let newval = newMetadata[k];
if (!this._compareAny(oldval,newval)) {
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]