[totem] strings: Revert use of Unicode ratio symbol in time strings
- From: Philip Withnall <pwithnall src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [totem] strings: Revert use of Unicode ratio symbol in time strings
- Date: Tue, 4 Dec 2012 18:54:47 +0000 (UTC)
commit cc9d8bab5b658c5450d6630fade340835b61d5e9
Author: Philip Withnall <philip tecnocode co uk>
Date: Tue Dec 4 18:50:13 2012 +0000
strings: Revert use of Unicode ratio symbol in time strings
âbut keep it for ratios. As pointed out on DDL, the ratio character is
semantically incorrect for times, and also has non-intuitive behaviour in
RtL locales.
See: https://mail.gnome.org/archives/desktop-devel-list/2012-December/msg00022.html
Helps: https://bugzilla.gnome.org/show_bug.cgi?id=621639
src/gst/totem-time-helpers.c | 12 ++++++------
src/plugins/skipto/totem-time-entry.c | 2 +-
2 files changed, 7 insertions(+), 7 deletions(-)
---
diff --git a/src/gst/totem-time-helpers.c b/src/gst/totem-time-helpers.c
index 9537580..71e9e82 100644
--- a/src/gst/totem-time-helpers.c
+++ b/src/gst/totem-time-helpers.c
@@ -48,19 +48,19 @@ totem_time_to_string (gint64 msecs)
if (hour > 0)
{
/* hour:minutes:seconds */
- /* Translators: This is a time format, like "9â05â02" for 9
- * hours, 5 minutes, and 2 seconds. You may change "â" to
+ /* Translators: This is a time format, like "9:05:02" for 9
+ * hours, 5 minutes, and 2 seconds. You may change ":" to
* the separator that your locale uses or use "%Id" instead
* of "%d" if your locale uses localized digits.
*/
- return g_strdup_printf (C_("long time format", "%dâ%02dâ%02d"), hour, min, sec);
+ return g_strdup_printf (C_("long time format", "%d:%02d:%02d"), hour, min, sec);
}
/* minutes:seconds */
- /* Translators: This is a time format, like "5â02" for 5
- * minutes and 2 seconds. You may change "â" to the
+ /* Translators: This is a time format, like "5:02" for 5
+ * minutes and 2 seconds. You may change ":" to the
* separator that your locale uses or use "%Id" instead of
* "%d" if your locale uses localized digits.
*/
- return g_strdup_printf (C_("short time format", "%dâ%02d"), min, sec);
+ return g_strdup_printf (C_("short time format", "%d:%02d"), min, sec);
}
diff --git a/src/plugins/skipto/totem-time-entry.c b/src/plugins/skipto/totem-time-entry.c
index cdda6dc..7b2e97b 100644
--- a/src/plugins/skipto/totem-time-entry.c
+++ b/src/plugins/skipto/totem-time-entry.c
@@ -54,7 +54,7 @@ totem_string_to_time (const char *time_string)
{
int sec, min, hour, args;
- args = sscanf (time_string, C_("long time format", "%dâ%02dâ%02d"), &hour, &min, &sec);
+ args = sscanf (time_string, C_("long time format", "%d:%02d:%02d"), &hour, &min, &sec);
if (args == 3) {
/* Parsed all three arguments successfully */
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]