[libgnome-keyring] Add more warnings about attributes not being stored securely



commit 9467812c61032ce1686690d2840655885652f74d
Author: Stef Walter <stefw gnome org>
Date:   Fri Aug 17 12:12:15 2012 +0200

    Add more warnings about attributes not being stored securely
    
     * Attributes in gnome-keyring are not (and not meant to be)
       stored sensitively.
     * Attributes are to be used for lookup of items, not storage.

 library/gnome-keyring-utils.c |    3 +++
 library/gnome-keyring.c       |    9 +++++++++
 2 files changed, 12 insertions(+), 0 deletions(-)
---
diff --git a/library/gnome-keyring-utils.c b/library/gnome-keyring-utils.c
index ed5c692..de59c84 100644
--- a/library/gnome-keyring-utils.c
+++ b/library/gnome-keyring-utils.c
@@ -275,6 +275,9 @@ gnome_keyring_found_list_free (GList *found_list)
  * These can also be used to search for relevant items. Use gnome_keyring_item_get_attributes()
  * or gnome_keyring_item_set_attributes().
  *
+ * Attributes are not stored in a secret or encrypted manner by gnome-keyring. Do
+ * not store sensitive information in attributes.
+ *
  * Each attribute has either a string, or unsigned integer value.
  **/
 
diff --git a/library/gnome-keyring.c b/library/gnome-keyring.c
index 13aad56..14ff556 100644
--- a/library/gnome-keyring.c
+++ b/library/gnome-keyring.c
@@ -2732,6 +2732,9 @@ gnome_keyring_find_itemsv_sync  (GnomeKeyringItemType        type,
  * Attributes allow various other pieces of information to be associated with an item.
  * These can also be used to search for relevant items. Attributes are accessed with
  * #GnomeKeyringAttribute structures and built into lists using #GnomeKeyringAttributeList.
+ *
+ * Attributes are not stored in a secret or encrypted manner by gnome-keyring. Do
+ * not store sensitive information in attributes.
  **/
 
 typedef struct _item_create_args {
@@ -4217,6 +4220,9 @@ gnome_keyring_item_grant_access_rights_sync (const char                   *keyri
  *
  * Networks passwords are a simple way of saving passwords associated with a
  * certain user/server/protocol and other fields.
+ *
+ * Attributes are not stored in a secret or encrypted manner by gnome-keyring. Do
+ * not store sensitive information in attributes.
  **/
 
 /**
@@ -4642,6 +4648,9 @@ gnome_keyring_set_network_password_sync (const char                            *
  * schema. Certain schemas are predefined such as %GNOME_KEYRING_NETWORK_PASSWORD.
  * Additional schemas can be defined via the %GnomeKeyringPasswordSchema structure.
  *
+ * Attributes are not stored in a secret or encrypted manner by gnome-keyring. Do
+ * not store sensitive information in attributes.
+ *
  * Each function accepts a variable list of attributes names and their values.
  * Include a %NULL to terminate the list of attributes.
  *



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]