[gimp] app: run dispose manually on the dialog factory before unrefing it



commit e7b16c86343dfacbe5c846275a2000708ffdf2a6
Author: Michael Natterer <mitch gimp org>
Date:   Thu Jun 24 12:51:46 2010 +0200

    app: run dispose manually on the dialog factory before unrefing it
    
    Because some of the dialogs the factory creates add a reference to
    it, creating a cycle; so simply unrefing it doesn't do anything.

 app/dialogs/dialogs.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)
---
diff --git a/app/dialogs/dialogs.c b/app/dialogs/dialogs.c
index 84ebe1f..b1ccfe4 100644
--- a/app/dialogs/dialogs.c
+++ b/app/dialogs/dialogs.c
@@ -421,6 +421,11 @@ dialogs_exit (Gimp *gimp)
 
   if (gimp_dialog_factory_get_singleton ())
     {
+      /* run dispose manually so the factory destroys its dialogs, which
+       * might in turn directly or indirectly ref the factory
+       */
+      g_object_run_dispose (G_OBJECT (gimp_dialog_factory_get_singleton ()));
+
       g_object_unref (gimp_dialog_factory_get_singleton ());
       gimp_dialog_factory_set_singleton (NULL);
     }



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]