[libgda] Misc code cleanups and optional debug info



commit c4e69a839b0c127428fd5b6b7ed15b0056718597
Author: Vivien Malerba <malerba gnome-db org>
Date:   Mon Sep 14 21:42:33 2009 +0200

    Misc code cleanups and optional debug info

 libgda-ui/gdaui-raw-grid.c         |   16 ++++++++--------
 libgda-ui/gdaui-set.c              |    1 -
 libgda/sqlite/gda-sqlite-blob-op.c |    5 ++++-
 3 files changed, 12 insertions(+), 10 deletions(-)
---
diff --git a/libgda-ui/gdaui-raw-grid.c b/libgda-ui/gdaui-raw-grid.c
index 5eedbec..c2af922 100644
--- a/libgda-ui/gdaui-raw-grid.c
+++ b/libgda-ui/gdaui-raw-grid.c
@@ -2406,7 +2406,7 @@ static GdaDataProxy *
 gdaui_raw_grid_get_proxy (GdauiDataWidget *iface)
 {
 	GdauiRawGrid *grid;
-	g_return_val_if_fail (iface && GDAUI_IS_RAW_GRID (iface), NULL);
+	g_return_val_if_fail (GDAUI_IS_RAW_GRID (iface), NULL);
 	grid = GDAUI_RAW_GRID (iface);
 	g_return_val_if_fail (grid->priv, NULL);
 
@@ -2421,7 +2421,7 @@ gdaui_raw_grid_set_column_editable (GdauiDataWidget *iface, gint column, gboolea
 	ColumnData *column_data;
 	GdauiSetGroup *group;
 
-	g_return_if_fail (iface && GDAUI_IS_RAW_GRID (iface));
+	g_return_if_fail (GDAUI_IS_RAW_GRID (iface));
 	grid = GDAUI_RAW_GRID (iface);
 	g_return_if_fail (grid->priv);
 	
@@ -2449,7 +2449,7 @@ gdaui_raw_grid_show_column_actions (GdauiDataWidget *iface, gint column, gboolea
 {
 	GdauiRawGrid *grid;
 
-	g_return_if_fail (iface && GDAUI_IS_RAW_GRID (iface));
+	g_return_if_fail (GDAUI_IS_RAW_GRID (iface));
 	grid = GDAUI_RAW_GRID (iface);
 	g_return_if_fail (grid->priv);
 
@@ -2496,7 +2496,7 @@ gdaui_raw_grid_col_set_show (GdauiDataWidget *iface, gint column, gboolean shown
 	GdaSetGroup *group;
 	GdaHolder *param;
 
-	g_return_if_fail (iface && GDAUI_IS_RAW_GRID (iface));
+	g_return_if_fail (GDAUI_IS_RAW_GRID (iface));
 	grid = GDAUI_RAW_GRID (iface);
 	g_return_if_fail (grid->priv);
 
@@ -2519,7 +2519,7 @@ gdaui_raw_grid_get_actions_group (GdauiDataWidget *iface)
 {
 	GdauiRawGrid *grid;
 	
-	g_return_val_if_fail (iface && GDAUI_IS_RAW_GRID (iface), NULL);
+	g_return_val_if_fail (GDAUI_IS_RAW_GRID (iface), NULL);
 	grid = GDAUI_RAW_GRID (iface);
 	g_return_val_if_fail (grid->priv, NULL);
 
@@ -2531,7 +2531,7 @@ gdaui_raw_grid_widget_get_data_set (GdauiDataWidget *iface)
 {
 	GdauiRawGrid *grid;
 	
-	g_return_val_if_fail (iface && GDAUI_IS_RAW_GRID (iface), NULL);
+	g_return_val_if_fail (GDAUI_IS_RAW_GRID (iface), NULL);
 	grid = GDAUI_RAW_GRID (iface);
 	g_return_val_if_fail (grid->priv, NULL);
 
@@ -2543,7 +2543,7 @@ static GdaDataModel *
 gdaui_raw_grid_widget_get_gda_model (GdauiDataWidget *iface)
 {
 	GdauiRawGrid *grid;
-	g_return_val_if_fail (iface && GDAUI_IS_RAW_GRID (iface), NULL);
+	g_return_val_if_fail (GDAUI_IS_RAW_GRID (iface), NULL);
 	grid = GDAUI_RAW_GRID (iface);
 	g_return_val_if_fail (grid->priv, NULL);
 
@@ -2724,7 +2724,7 @@ gdaui_raw_grid_widget_set_gda_model (GdauiDataWidget *iface, GdaDataModel *model
 {
 	GdauiRawGrid *grid;
 
-	g_return_if_fail (iface && GDAUI_IS_RAW_GRID (iface));
+	g_return_if_fail (GDAUI_IS_RAW_GRID (iface));
 	grid = GDAUI_RAW_GRID (iface);
 	g_return_if_fail (grid->priv);
 	
diff --git a/libgda-ui/gdaui-set.c b/libgda-ui/gdaui-set.c
index 620edd6..11a70ee 100644
--- a/libgda-ui/gdaui-set.c
+++ b/libgda-ui/gdaui-set.c
@@ -211,7 +211,6 @@ wrapped_set_public_data_changed_cb (GdaSet *wset, GdauiSet *set)
 static void
 clean_public_data (GdauiSet *set)
 {
-	TO_IMPLEMENT;
 	GSList *list;
 	
 	for (list = set->sources_list; list; list = list->next) {
diff --git a/libgda/sqlite/gda-sqlite-blob-op.c b/libgda/sqlite/gda-sqlite-blob-op.c
index ceaa4b1..cf9343d 100644
--- a/libgda/sqlite/gda-sqlite-blob-op.c
+++ b/libgda/sqlite/gda-sqlite-blob-op.c
@@ -102,8 +102,10 @@ gda_sqlite_blob_op_finalize (GObject * object)
 	g_return_if_fail (GDA_IS_SQLITE_BLOB_OP (bop));
 
 	/* free specific information */
-	if (bop->priv->sblob)
+	if (bop->priv->sblob) {
 		sqlite3_blob_close (bop->priv->sblob);
+		/* g_print ("CLOSED blob %p\n", bop); */
+	}
 	g_free (bop->priv);
 	bop->priv = NULL;
 
@@ -141,6 +143,7 @@ _gda_sqlite_blob_op_new (SqliteConnectionData *cdata, const gchar *db_name, cons
 
 	bop = g_object_new (GDA_TYPE_SQLITE_BLOB_OP, NULL);
 	bop->priv->sblob = sblob;
+	/* g_print ("OPENED blob %p\n", bop); */
 
  out:
 	if (free_strings) {



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]