gimp r28053 - in trunk: . app/display app/tools

[mitch svn gnome org]

Author: mitch
Date: Fri Feb 20 16:57:26 2009
New Revision: 28053
URL: http://svn.gnome.org/viewvc/gimp?rev=28053&view=rev

Log:
2009-02-20  Michael Natterer  <mitch gimp org>

	Bug 572156 â top left pixel position/coordinate is not 0,0 but 1,1

	* app/display/gimpstatusbar.c
	(gimp_statusbar_push_coords)
	(gimp_statusbar_update_cursor): fix braino for
	GIMP_CURSOR_PRECISION_PIXEL_CENTER: going to the pixel's
	center doesn't need any rounding, it simply needs clipping
	the coordinates' fractional parts, gah...

	Review all tools' cursor precision:

	* app/tools/gimpblendtool.c (gimp_blend_tool_init): set cursor
	precision to SUBPIXEL.

	* app/tools/gimptexttool.c (gimp_text_tool_init)
	* app/tools/gimpmeasuretool.c (gimp_measure_tool_init)
	* app/tools/gimpeditselectiontool.c (gimp_edit_selection_tool_init):
	set cursor precision to PIXEL_BORDER.



Modified:
   trunk/ChangeLog
   trunk/app/display/gimpstatusbar.c
   trunk/app/tools/gimpblendtool.c
   trunk/app/tools/gimpeditselectiontool.c
   trunk/app/tools/gimpmeasuretool.c
   trunk/app/tools/gimptexttool.c

Modified: trunk/app/display/gimpstatusbar.c
==============================================================================
--- trunk/app/display/gimpstatusbar.c	(original)
+++ trunk/app/display/gimpstatusbar.c	Fri Feb 20 16:57:26 2009
@@ -817,8 +817,8 @@
   switch (precision)
     {
     case GIMP_CURSOR_PRECISION_PIXEL_CENTER:
-      x = RINT (x + 0.5);
-      y = RINT (y + 0.5);
+      x = (gint) x;
+      y = (gint) y;
       break;
 
     case GIMP_CURSOR_PRECISION_PIXEL_BORDER:
@@ -1192,8 +1192,8 @@
   switch (precision)
     {
     case GIMP_CURSOR_PRECISION_PIXEL_CENTER:
-      x = RINT (x + 0.5);
-      y = RINT (y + 0.5);
+      x = (gint) x;
+      y = (gint) y;
       break;
 
     case GIMP_CURSOR_PRECISION_PIXEL_BORDER:

Modified: trunk/app/tools/gimpblendtool.c
==============================================================================
--- trunk/app/tools/gimpblendtool.c	(original)
+++ trunk/app/tools/gimpblendtool.c	Fri Feb 20 16:57:26 2009
@@ -135,6 +135,8 @@
   GimpTool *tool = GIMP_TOOL (blend_tool);
 
   gimp_tool_control_set_scroll_lock     (tool->control, TRUE);
+  gimp_tool_control_set_precision       (tool->control,
+                                         GIMP_CURSOR_PRECISION_SUBPIXEL);
   gimp_tool_control_set_cursor          (tool->control,
                                          GIMP_CURSOR_MOUSE);
   gimp_tool_control_set_tool_cursor     (tool->control,

Modified: trunk/app/tools/gimpeditselectiontool.c
==============================================================================
--- trunk/app/tools/gimpeditselectiontool.c	(original)
+++ trunk/app/tools/gimpeditselectiontool.c	Fri Feb 20 16:57:26 2009
@@ -148,8 +148,6 @@
 
   gimp_tool_control_set_scroll_lock (tool->control, EDIT_SELECT_SCROLL_LOCK);
   gimp_tool_control_set_motion_mode (tool->control, GIMP_MOTION_MODE_COMPRESS);
-  gimp_tool_control_set_precision   (tool->control,
-                                     GIMP_CURSOR_PRECISION_PIXEL_BORDER);
 
   edit_selection_tool->origx      = 0;
   edit_selection_tool->origy      = 0;

Modified: trunk/app/tools/gimpmeasuretool.c
==============================================================================
--- trunk/app/tools/gimpmeasuretool.c	(original)
+++ trunk/app/tools/gimpmeasuretool.c	Fri Feb 20 16:57:26 2009
@@ -149,8 +149,11 @@
   GimpTool *tool = GIMP_TOOL (measure_tool);
 
   gimp_tool_control_set_handle_empty_image (tool->control, TRUE);
+  gimp_tool_control_set_precision          (tool->control,
+                                            GIMP_CURSOR_PRECISION_PIXEL_BORDER);
   gimp_tool_control_set_tool_cursor        (tool->control,
                                             GIMP_TOOL_CURSOR_MEASURE);
+
   measure_tool->function = CREATING;
   measure_tool->status_help = TRUE;
 }

Modified: trunk/app/tools/gimptexttool.c
==============================================================================
--- trunk/app/tools/gimptexttool.c	(original)
+++ trunk/app/tools/gimptexttool.c	Fri Feb 20 16:57:26 2009
@@ -285,6 +285,8 @@
 
   gimp_tool_control_set_scroll_lock          (tool->control, TRUE);
   gimp_tool_control_set_wants_all_key_events (tool->control, TRUE);
+  gimp_tool_control_set_precision            (tool->control,
+                                              GIMP_CURSOR_PRECISION_PIXEL_BORDER);
   gimp_tool_control_set_tool_cursor          (tool->control,
                                               GIMP_TOOL_CURSOR_TEXT);
   gimp_tool_control_set_action_object_1      (tool->control,