[gnome-shell] Catch exception trying to create a preview of an unknown image type



commit b51bcf3e2b8c90d34a2fcf7726b11156c2241377
Author: Siegfried-Angel Gevatter Pujals <rainct ubuntu com>
Date:   Wed Aug 12 01:30:58 2009 +0200

    Catch exception trying to create a preview of an unknown image type

 js/ui/docDisplay.js |   11 +++++++++--
 1 files changed, 9 insertions(+), 2 deletions(-)
---
diff --git a/js/ui/docDisplay.js b/js/ui/docDisplay.js
index a1cc71c..d2d4fa3 100644
--- a/js/ui/docDisplay.js
+++ b/js/ui/docDisplay.js
@@ -72,8 +72,15 @@ DocDisplayItem.prototype = {
         if (this._docInfo.mimeType == null || this._docInfo.mimeType.indexOf("image/") != 0)
             return null;
 
-        return Shell.TextureCache.get_default().load_uri_sync(Shell.TextureCachePolicy.NONE,
-                                                              this._docInfo.uri, availableWidth, availableHeight);
+        try {
+            return Shell.TextureCache.get_default().load_uri_sync(Shell.TextureCachePolicy.NONE,
+                                                                  this._docInfo.uri, availableWidth, availableHeight);
+        } catch (e) {
+            // An exception will be raised when the image format isn't know
+            /* FIXME: http://bugzilla.gnome.org/show_bug.cgi?id=591480: should
+             *        only ignore GDK_PIXBUF_ERROR_UNKNOWN_TYPE. */
+            return null;
+        }
     },
 
     //// Private Methods ////



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]