beagle r3255 - trunk/beagle/beagled



Author: dbera
Date: 2007-01-13 19:56:45 +0000 (Sat, 13 Jan 2007)
New Revision: 3255
ViewCVS link: http://svn.gnome.org/viewcvs/beagle?rev=3255&view=rev

Modified:
   trunk/beagle/beagled/FileAttributesStore.cs
Log:
Do not actually write an attribute when asked to ReadOrCreate. To me its against the semantics of the method, I would expect to give me the attr if present or return me a default attr that I can do some modification and write back. Moreover, ReadOrCreate was writing attributes with default values for mtime and attr_time. There is a possibility that the attr returned by ReadOrCreate will not written back (in FSQ), in which case an attribute will be present in the system which it should not be.

This should not break anything; I left the line commented to remind myself to evaluate the situation.





[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]