Re: [xml] Useless mutex in struct _xmlDict

[Daniel Veillard <veillard redhat com>]

On Thu, Jan 24, 2008 at 04:08:47PM +0100, Florent Guiliani wrote:
> Florent Guiliani a écrit :
> > Hi all,
> > 
> > A "xmlRMutexPtr mutex" was introduced in "struct _xmlDict" by SVN 
> > revision#2947
> > (svn diff -c 2947 http://svn.gnome.org/svn/libxml2/trunk/dict.c).
> > 
> > A global "static xmlRMutexPtr xmlDictMutex" was prefered to this by-dict 
> > mutex in revision#2948
> > (svn diff -c 2948 http://svn.gnome.org/svn/libxml2/trunk/dict.c).
> > 
> > But the original by-dict mutex is still present in "struct _xmlDict" and 
> > is no more used.
> > (svn cat -r HEAD http://svn.gnome.org/svn/libxml2/trunk/dict.c)
> > 
> > I've attached a patch that remove this unused mutex.
> 
> May I omited to say that the attached patch can be applied directly on trunk? or 
> do I missed something else in the "sending patch guidelines"?

 No it's just that I was on the road at that time. Patch is fine,
so I applied it and commited to SVN, thanks !

 BTW how did you spot this, I doubt this can show up in runtime profiling
so I'm wondering ...

Daniel

-- 
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard      | virtualization library  http://libvirt.org/
veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine  http://rpmfind.net/