Re: [xml] memory leak in xmlXPathErr?

[Daniel Veillard <veillard redhat com>]

On Tue, May 30, 2006 at 04:58:35PM -0700, Aleksey Sanin wrote:
> Hello, All!
> 
> I believe I run into a memory leak in xmlXPathErr() with the
> following (incorrect) XPath expression:
> 
> 	//billing/xtext()
> 
> In this case, LibXML2 first reports an error from xmlXPathCompNodeTest()
> function (some function parameters are removed in the stack trace):
[...]
> 
> The proposed fix is trivial: just add one line to xmlXPathErr() function
> right before the update "ctxt->context->lastError" variable:
> 
> xmlResetError(&ctxt->context->lastError);
> 
> Any objection if I make this change?

  No objection, that sounds right !

Daniel

-- 
Daniel Veillard      | Red Hat http://redhat.com/
veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/